* [PATCH] ANDROID: i2c: exynos5: remove default enable in Kconfig
@ 2019-12-05 15:04 Hyunki Koo
2019-12-05 15:29 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Hyunki Koo @ 2019-12-05 15:04 UTC (permalink / raw)
To: wsa
Cc: Hyunki Koo, Jean Delvare, Jarkko Nikula, Alexandre Belloni,
Max Staudt, Juergen Fitschen, Krzysztof Kozlowski, Elie Morisse,
Stefan Roese, Baolin Wang, Arnd Bergmann, Mauro Carvalho Chehab,
linux-i2c, linux-kernel
From: Hyunki Koo <hyunki00.koo@samsung.com>
There are many exynos device and not all exynos device does not have
HSI2C controllers. Thus remove select this by default
Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
---
drivers/i2c/busses/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 6a0aa76859f3..3955315f48c7 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -612,7 +612,6 @@ config I2C_EMEV2
config I2C_EXYNOS5
tristate "Exynos5 high-speed I2C driver"
depends on ARCH_EXYNOS && OF
- default y
help
High-speed I2C controller on Exynos5 based Samsung SoCs.
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ANDROID: i2c: exynos5: remove default enable in Kconfig
2019-12-05 15:04 [PATCH] ANDROID: i2c: exynos5: remove default enable in Kconfig Hyunki Koo
@ 2019-12-05 15:29 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2019-12-05 15:29 UTC (permalink / raw)
To: Hyunki Koo
Cc: wsa, Hyunki Koo, Jean Delvare, Jarkko Nikula, Alexandre Belloni,
Max Staudt, Juergen Fitschen, Elie Morisse, Stefan Roese,
Baolin Wang, Arnd Bergmann, Mauro Carvalho Chehab, linux-i2c,
linux-kernel@vger.kernel.org
On Thu, 5 Dec 2019 at 16:05, Hyunki Koo <hyunki00.koo@gmail.com> wrote:
>
> From: Hyunki Koo <hyunki00.koo@samsung.com>
>
> There are many exynos device and not all exynos device does not have
> HSI2C controllers. Thus remove select this by default
>
> Signed-off-by: Hyunki Koo <hyunki00.koo@samsung.com>
> ---
> drivers/i2c/busses/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
Thanks for the patch but this is not a proper solution because:
1. Basically you disabled this driver on exynos, multi_v7 and ARMv8 defconfigs.
2. We provide one kernel for all ARMv7 Exynos and one for all ARMv8
platforms therefore this driver should be there. Having unnecessary
driver also does not hurt - it will not match by compatible.
So really no.
Best regards,
Krzysztof
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 6a0aa76859f3..3955315f48c7 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -612,7 +612,6 @@ config I2C_EMEV2
> config I2C_EXYNOS5
> tristate "Exynos5 high-speed I2C driver"
> depends on ARCH_EXYNOS && OF
> - default y
> help
> High-speed I2C controller on Exynos5 based Samsung SoCs.
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-05 15:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-05 15:04 [PATCH] ANDROID: i2c: exynos5: remove default enable in Kconfig Hyunki Koo
2019-12-05 15:29 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox