* [PATCH] i2c:imx-lpi2c: Omit superfluous error message in lpi2c_imx_probe()
@ 2020-04-16 14:05 Tang Bin
2020-04-16 14:11 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Tang Bin @ 2020-04-16 14:05 UTC (permalink / raw)
To: aisheng.dong, shawnguo, s.hauer, kernel, festevam, linux-imx
Cc: linux-i2c, linux-arm-kernel, linux-kernel, Tang Bin
In the function lpi2c_imx_probe(), when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant message
here.
Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
---
drivers/i2c/busses/i2c-imx-lpi2c.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-imx-lpi2c.c b/drivers/i2c/busses/i2c-imx-lpi2c.c
index c92b56485..ee16e7e22 100644
--- a/drivers/i2c/busses/i2c-imx-lpi2c.c
+++ b/drivers/i2c/busses/i2c-imx-lpi2c.c
@@ -557,10 +557,8 @@ static int lpi2c_imx_probe(struct platform_device *pdev)
return PTR_ERR(lpi2c_imx->base);
irq = platform_get_irq(pdev, 0);
- if (irq < 0) {
- dev_err(&pdev->dev, "can't get irq number\n");
+ if (irq < 0)
return irq;
- }
lpi2c_imx->adapter.owner = THIS_MODULE;
lpi2c_imx->adapter.algo = &lpi2c_imx_algo;
--
2.20.1.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] i2c:imx-lpi2c: Omit superfluous error message in lpi2c_imx_probe()
2020-04-16 14:05 [PATCH] i2c:imx-lpi2c: Omit superfluous error message in lpi2c_imx_probe() Tang Bin
@ 2020-04-16 14:11 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2020-04-16 14:11 UTC (permalink / raw)
To: Tang Bin
Cc: aisheng.dong, shawnguo, s.hauer, kernel, festevam, linux-imx,
linux-i2c, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 349 bytes --]
On Thu, Apr 16, 2020 at 10:05:29PM +0800, Tang Bin wrote:
> In the function lpi2c_imx_probe(), when get irq failed, the function
> platform_get_irq() logs an error message, so remove redundant message
> here.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
Please make only one patch for all the drivers in the i2c subsystem.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-16 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-16 14:05 [PATCH] i2c:imx-lpi2c: Omit superfluous error message in lpi2c_imx_probe() Tang Bin
2020-04-16 14:11 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox