* [PATCH 1/1] Documentation/i2c: SMBus start signal is S not A
@ 2020-06-14 18:23 git
2020-06-14 18:57 ` Daniel Schäfer
2020-06-19 7:24 ` Wolfram Sang
0 siblings, 2 replies; 4+ messages in thread
From: git @ 2020-06-14 18:23 UTC (permalink / raw)
To: linux-i2c; +Cc: Daniel Schaefer, Wolfram Sang
From: Daniel Schaefer <git@danielschaefer.me>
Just like all other I2C/SMBus commands, the start signal for the SMBus
Quick Command is S, not P.
Cc: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
---
Documentation/i2c/smbus-protocol.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/i2c/smbus-protocol.rst b/Documentation/i2c/smbus-protocol.rst
index c2e29633071e..64689d19dd51 100644
--- a/Documentation/i2c/smbus-protocol.rst
+++ b/Documentation/i2c/smbus-protocol.rst
@@ -57,7 +57,7 @@ SMBus Quick Command
This sends a single bit to the device, at the place of the Rd/Wr bit::
- A Addr Rd/Wr [A] P
+ S Addr Rd/Wr [A] P
Functionality flag: I2C_FUNC_SMBUS_QUICK
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Documentation/i2c: SMBus start signal is S not A
2020-06-14 18:23 [PATCH 1/1] Documentation/i2c: SMBus start signal is S not A git
@ 2020-06-14 18:57 ` Daniel Schäfer
2020-06-14 19:45 ` Wolfram Sang
2020-06-19 7:24 ` Wolfram Sang
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Schäfer @ 2020-06-14 18:57 UTC (permalink / raw)
To: linux-i2c; +Cc: git, Wolfram Sang
On 6/14/20 8:23 PM, git@danielschaefer.me wrote:
> From: Daniel Schaefer <git@danielschaefer.me>
>
> Just like all other I2C/SMBus commands, the start signal for the SMBus
> Quick Command is S, not P.
Oops, should be 'not A' here, like in the commit title. Will you fix
that up while applying please, or should I send a new patch?
>
> Cc: Wolfram Sang <wsa@kernel.org>
> Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
> ---
> Documentation/i2c/smbus-protocol.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/i2c/smbus-protocol.rst b/Documentation/i2c/smbus-protocol.rst
> index c2e29633071e..64689d19dd51 100644
> --- a/Documentation/i2c/smbus-protocol.rst
> +++ b/Documentation/i2c/smbus-protocol.rst
> @@ -57,7 +57,7 @@ SMBus Quick Command
>
> This sends a single bit to the device, at the place of the Rd/Wr bit::
>
> - A Addr Rd/Wr [A] P
> + S Addr Rd/Wr [A] P
>
> Functionality flag: I2C_FUNC_SMBUS_QUICK
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Documentation/i2c: SMBus start signal is S not A
2020-06-14 18:57 ` Daniel Schäfer
@ 2020-06-14 19:45 ` Wolfram Sang
0 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2020-06-14 19:45 UTC (permalink / raw)
To: Daniel Schäfer; +Cc: linux-i2c, git
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Sun, Jun 14, 2020 at 08:57:30PM +0200, Daniel Schäfer wrote:
> On 6/14/20 8:23 PM, git@danielschaefer.me wrote:
> > From: Daniel Schaefer <git@danielschaefer.me>
> >
> > Just like all other I2C/SMBus commands, the start signal for the SMBus
> > Quick Command is S, not P.
>
> Oops, should be 'not A' here, like in the commit title. Will you fix
> that up while applying please, or should I send a new patch?
I will fix it. And congrats for catching this typo which exists longer
than the git history!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] Documentation/i2c: SMBus start signal is S not A
2020-06-14 18:23 [PATCH 1/1] Documentation/i2c: SMBus start signal is S not A git
2020-06-14 18:57 ` Daniel Schäfer
@ 2020-06-19 7:24 ` Wolfram Sang
1 sibling, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2020-06-19 7:24 UTC (permalink / raw)
To: git; +Cc: linux-i2c
[-- Attachment #1: Type: text/plain, Size: 365 bytes --]
On Sun, Jun 14, 2020 at 08:23:55PM +0200, git@danielschaefer.me wrote:
> From: Daniel Schaefer <git@danielschaefer.me>
>
> Just like all other I2C/SMBus commands, the start signal for the SMBus
> Quick Command is S, not P.
>
> Cc: Wolfram Sang <wsa@kernel.org>
> Signed-off-by: Daniel Schaefer <git@danielschaefer.me>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-06-19 7:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-14 18:23 [PATCH 1/1] Documentation/i2c: SMBus start signal is S not A git
2020-06-14 18:57 ` Daniel Schäfer
2020-06-14 19:45 ` Wolfram Sang
2020-06-19 7:24 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox