From: Wolfram Sang <wsa@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Mohammed Billoo <mab@mab-labs.com>,
Peter Korsgaard <peter@korsgaard.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 2/2] i2c: ocores: add be/le support for gaisler
Date: Fri, 14 Aug 2020 21:05:15 +0200 [thread overview]
Message-ID: <20200814190515.GA1250@kunai> (raw)
In-Reply-To: <20200814190259.GD2239279@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 837 bytes --]
On Fri, Aug 14, 2020 at 09:02:59PM +0200, Andrew Lunn wrote:
> On Fri, Aug 14, 2020 at 02:56:58PM -0400, Mohammed Billoo wrote:
> > Sadly, this is a case of vendor-specific implementations causing indigestion.
> > When this was implemented on the FPGA, the vendor-specific AHB bridge (we're
> > going from PCI to AHB to grlib) had a built-in endianness conversion which we
> > didn't want and found out later. Since it was easier to add the big endian
> > accessor on the software side instead of redoing the FPGA design, we opted for
> > the former.
>
> O.K. So please document this is a workaround for broken hardware.
> Otherwise other people are going to ask the same question. Add it to
> the commit message at least.
Very true, this should be documented. I think a comment in the source
code makes more sense.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-08-14 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 16:31 [PATCH 1/2] i2c: ocores: add gaisler to platform data Mohammed Billoo
2020-08-14 16:31 ` [PATCH 2/2] i2c: ocores: add be/le support for gaisler Mohammed Billoo
2020-08-14 16:50 ` Andrew Lunn
[not found] ` <CALkjhPppeOwekp-ZJZ9QGfNGa=K5g6P+TWs42Anrb+QvFSrspQ@mail.gmail.com>
2020-08-14 19:02 ` Andrew Lunn
2020-08-14 19:05 ` Wolfram Sang [this message]
2020-08-14 16:49 ` [PATCH 1/2] i2c: ocores: add gaisler to platform data Andrew Lunn
[not found] ` <CALkjhPo3BGRDao=Rz9S5Xxf1bubBXv7WEGu6B=5V1WvnmGUmwg@mail.gmail.com>
2020-08-14 19:04 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814190515.GA1250@kunai \
--to=wsa@kernel.org \
--cc=andrew@lunn.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=mab@mab-labs.com \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox