From: Andrew Lunn <andrew@lunn.ch>
To: Mohammed Billoo <mab@mab-labs.com>
Cc: Peter Korsgaard <peter@korsgaard.com>, linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: ocores: add gaisler to platform data
Date: Fri, 14 Aug 2020 21:04:59 +0200 [thread overview]
Message-ID: <20200814190459.GE2239279@lunn.ch> (raw)
In-Reply-To: <CALkjhPo3BGRDao=Rz9S5Xxf1bubBXv7WEGu6B=5V1WvnmGUmwg@mail.gmail.com>
On Fri, Aug 14, 2020 at 02:53:20PM -0400, Mohammed Billoo wrote:
> Andrew,
>
> Thanks for the feedback. That makes sense.
>
> My use case was very specific that required these changes and I thought I'd
> push them upstream for others. Basically, we have an FPGA over PCI that has
> some IP, vendor-specific bridging to AHB, and then grlib to go to i2c (among
> other controllers). When we load the pci driver we create and add a mfd device
> that has the specific BAR as the resource, and the offset within the BAR for
> the i2c controller. Looking back, all of this could be added to the device
> tree, so what we've done so far may be an anti-pattern.
>
> Would you still want this patch?
I would prefer device tree.
Andrew
prev parent reply other threads:[~2020-08-14 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 16:31 [PATCH 1/2] i2c: ocores: add gaisler to platform data Mohammed Billoo
2020-08-14 16:31 ` [PATCH 2/2] i2c: ocores: add be/le support for gaisler Mohammed Billoo
2020-08-14 16:50 ` Andrew Lunn
[not found] ` <CALkjhPppeOwekp-ZJZ9QGfNGa=K5g6P+TWs42Anrb+QvFSrspQ@mail.gmail.com>
2020-08-14 19:02 ` Andrew Lunn
2020-08-14 19:05 ` Wolfram Sang
2020-08-14 16:49 ` [PATCH 1/2] i2c: ocores: add gaisler to platform data Andrew Lunn
[not found] ` <CALkjhPo3BGRDao=Rz9S5Xxf1bubBXv7WEGu6B=5V1WvnmGUmwg@mail.gmail.com>
2020-08-14 19:04 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200814190459.GE2239279@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-i2c@vger.kernel.org \
--cc=mab@mab-labs.com \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox