* [PATCH] i2c: Remove 'default n' from busses/Kconfig
@ 2020-08-20 8:05 Jarkko Nikula
2020-08-25 7:08 ` Wolfram Sang
2020-08-25 7:28 ` Jean Delvare
0 siblings, 2 replies; 5+ messages in thread
From: Jarkko Nikula @ 2020-08-20 8:05 UTC (permalink / raw)
To: linux-i2c; +Cc: Wolfram Sang, Jean Delvare, Jarkko Nikula
The default value for a config option defaults to 'n' so it doesn't need
to be set here.
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
---
drivers/i2c/busses/Kconfig | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 085ca9b009ed..9731121ec561 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -840,7 +840,6 @@ config I2C_PASEMI
config I2C_PCA_PLATFORM
tristate "PCA9564/PCA9665 as platform device"
select I2C_ALGOPCA
- default n
help
This driver supports a memory mapped Philips PCA9564/PCA9665
parallel bus to I2C bus controller.
@@ -1251,7 +1250,6 @@ config I2C_TAOS_EVM
depends on TTY
select SERIO
select SERIO_SERPORT
- default n
help
This supports TAOS evaluation modules on serial port. In order to
use this driver, you will need the inputattach tool, which is part
@@ -1335,7 +1333,6 @@ config I2C_PCA_ISA
tristate "PCA9564/PCA9665 on an ISA bus"
depends on ISA
select I2C_ALGOPCA
- default n
help
This driver supports ISA boards using the Philips PCA9564/PCA9665
parallel bus to I2C bus controller.
--
2.28.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: Remove 'default n' from busses/Kconfig
2020-08-20 8:05 [PATCH] i2c: Remove 'default n' from busses/Kconfig Jarkko Nikula
@ 2020-08-25 7:08 ` Wolfram Sang
2020-08-25 7:28 ` Jean Delvare
1 sibling, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2020-08-25 7:08 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-i2c, Jean Delvare
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
On Thu, Aug 20, 2020 at 11:05:25AM +0300, Jarkko Nikula wrote:
> The default value for a config option defaults to 'n' so it doesn't need
> to be set here.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: Remove 'default n' from busses/Kconfig
2020-08-20 8:05 [PATCH] i2c: Remove 'default n' from busses/Kconfig Jarkko Nikula
2020-08-25 7:08 ` Wolfram Sang
@ 2020-08-25 7:28 ` Jean Delvare
2020-08-25 7:51 ` Wolfram Sang
1 sibling, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2020-08-25 7:28 UTC (permalink / raw)
To: Jarkko Nikula; +Cc: linux-i2c, Wolfram Sang
On Thu, 20 Aug 2020 11:05:25 +0300, Jarkko Nikula wrote:
> The default value for a config option defaults to 'n' so it doesn't need
> to be set here.
>
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> ---
> drivers/i2c/busses/Kconfig | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 085ca9b009ed..9731121ec561 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -840,7 +840,6 @@ config I2C_PASEMI
> config I2C_PCA_PLATFORM
> tristate "PCA9564/PCA9665 as platform device"
> select I2C_ALGOPCA
> - default n
> help
> This driver supports a memory mapped Philips PCA9564/PCA9665
> parallel bus to I2C bus controller.
> @@ -1251,7 +1250,6 @@ config I2C_TAOS_EVM
> depends on TTY
> select SERIO
> select SERIO_SERPORT
> - default n
> help
> This supports TAOS evaluation modules on serial port. In order to
> use this driver, you will need the inputattach tool, which is part
> @@ -1335,7 +1333,6 @@ config I2C_PCA_ISA
> tristate "PCA9564/PCA9665 on an ISA bus"
> depends on ISA
> select I2C_ALGOPCA
> - default n
> help
> This driver supports ISA boards using the Philips PCA9564/PCA9665
> parallel bus to I2C bus controller.
Definitely a good move, this was on my informal to-do list for some
time already...
Option I2C_STUB suffers from the same but uses a different syntax,
which may explain why you missed it.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: Remove 'default n' from busses/Kconfig
2020-08-25 7:28 ` Jean Delvare
@ 2020-08-25 7:51 ` Wolfram Sang
2020-08-25 7:58 ` Jarkko Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Wolfram Sang @ 2020-08-25 7:51 UTC (permalink / raw)
To: Jean Delvare; +Cc: Jarkko Nikula, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 222 bytes --]
> Option I2C_STUB suffers from the same but uses a different syntax,
> which may explain why you missed it.
>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
I removed that one, too, and added your tag. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] i2c: Remove 'default n' from busses/Kconfig
2020-08-25 7:51 ` Wolfram Sang
@ 2020-08-25 7:58 ` Jarkko Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jarkko Nikula @ 2020-08-25 7:58 UTC (permalink / raw)
To: Wolfram Sang, Jean Delvare; +Cc: linux-i2c
On 8/25/20 10:51 AM, Wolfram Sang wrote:
>
>> Option I2C_STUB suffers from the same but uses a different syntax,
>> which may explain why you missed it.
>>
>> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>
> I removed that one, too, and added your tag. Thanks!
>
Ah, thanks! I was just going to send another patch removing it :-)
Jarkko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-08-25 7:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-08-20 8:05 [PATCH] i2c: Remove 'default n' from busses/Kconfig Jarkko Nikula
2020-08-25 7:08 ` Wolfram Sang
2020-08-25 7:28 ` Jean Delvare
2020-08-25 7:51 ` Wolfram Sang
2020-08-25 7:58 ` Jarkko Nikula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox