From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Evan Nimmo <evan.nimmo@alliedtelesis.co.nz>
Cc: wsa@kernel.org, jarkko.nikula@linux.intel.com, jdelvare@suse.de,
chris.packham@alliedtelesis.co.nz, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] i2c: algo-pca: Reapply i2c bus settings after reset
Date: Wed, 2 Sep 2020 11:45:38 +0300 [thread overview]
Message-ID: <20200902084538.GY1891694@smile.fi.intel.com> (raw)
In-Reply-To: <20200902084356.GX1891694@smile.fi.intel.com>
On Wed, Sep 02, 2020 at 11:43:56AM +0300, Andy Shevchenko wrote:
> On Wed, Sep 02, 2020 at 09:17:47AM +1200, Evan Nimmo wrote:
> > If something goes wrong (such as the SCL being stuck low) then we need
> > to reset the PCA chip. The issue with this is that on reset we lose all
> > config settings and the chip ends up in a disabled state which results
> > in a lock up/high cpu usage. We need to re-apply any configuration that
>
> cpu -> CPU (I guess Wolfram can decide with this when applying)
>
> > had previously been set and re-enable the chip.
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
And actually you forgot Chris' tag... But I dunno if the moving struct
definition is something that Chris might not like.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-09-02 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 21:17 [PATCH v2 1/1] i2c: algo-pca: Reapply i2c bus settings after reset Evan Nimmo
2020-09-02 8:43 ` Andy Shevchenko
2020-09-02 8:45 ` Andy Shevchenko [this message]
2020-09-02 20:57 ` Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902084538.GY1891694@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=evan.nimmo@alliedtelesis.co.nz \
--cc=jarkko.nikula@linux.intel.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox