From: Wolfram Sang <wsa@kernel.org>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Kamal Dasu <kdasu.kdev@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH] i2c: brcmstb: Fix brcmstd_send_i2c_cmd condition
Date: Thu, 25 Feb 2021 19:31:55 +0100 [thread overview]
Message-ID: <20210225183155.GA3072@kunai> (raw)
In-Reply-To: <20210225161101.1856192-1-maxime@cerno.tech>
[-- Attachment #1: Type: text/plain, Size: 704 bytes --]
On Thu, Feb 25, 2021 at 05:11:01PM +0100, Maxime Ripard wrote:
> The brcmstb_send_i2c_cmd currently has a condition that is (CMD_RD ||
> CMD_WR) which always evaluates to true, while the obvious fix is to test
> whether the cmd variable passed as parameter holds one of these two
> values.
>
> Reported-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
I got a feeling of deja vu...
... and, in deed, I already fixed this, too, one year ago:
http://patchwork.ozlabs.org/project/linux-i2c/patch/20200426081211.10876-1-wsa+renesas@sang-engineering.com/
Dunno why it never appeared in a pull request :(
I'll pick this one, now!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-02-25 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 16:11 [PATCH] i2c: brcmstb: Fix brcmstd_send_i2c_cmd condition Maxime Ripard
2021-02-25 16:16 ` Florian Fainelli
2021-02-25 18:31 ` Wolfram Sang [this message]
2021-02-26 10:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210225183155.GA3072@kunai \
--to=wsa@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=f.fainelli@gmail.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=maxime@cerno.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox