From: Florian Fainelli <f.fainelli@gmail.com>
To: Maxime Ripard <maxime@cerno.tech>,
Kamal Dasu <kdasu.kdev@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Wolfram Sang <wsa@kernel.org>
Cc: bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH] i2c: brcmstb: Fix brcmstd_send_i2c_cmd condition
Date: Thu, 25 Feb 2021 08:16:07 -0800 [thread overview]
Message-ID: <8edadda5-ca19-6cc4-d539-2dec848fb73d@gmail.com> (raw)
In-Reply-To: <20210225161101.1856192-1-maxime@cerno.tech>
On 2/25/2021 8:11 AM, Maxime Ripard wrote:
> The brcmstb_send_i2c_cmd currently has a condition that is (CMD_RD ||
> CMD_WR) which always evaluates to true, while the obvious fix is to test
> whether the cmd variable passed as parameter holds one of these two
> values.
>
> Reported-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Fixes: dd1aa2524bc5 ("i2c: brcmstb: Add Broadcom settop SoC i2c
controller driver")
Thanks!
--
Florian
next prev parent reply other threads:[~2021-02-25 16:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 16:11 [PATCH] i2c: brcmstb: Fix brcmstd_send_i2c_cmd condition Maxime Ripard
2021-02-25 16:16 ` Florian Fainelli [this message]
2021-02-25 18:31 ` Wolfram Sang
2021-02-26 10:24 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8edadda5-ca19-6cc4-d539-2dec848fb73d@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=kdasu.kdev@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=maxime@cerno.tech \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox