From: Jean Delvare <jdelvare@suse.de>
To: zuoqilin1@163.com
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
zuoqilin <zuoqilin@yulong.com>
Subject: Re: [PATCH] i2c/busses: fix spellint typo
Date: Sat, 27 Feb 2021 11:00:01 +0100 [thread overview]
Message-ID: <20210227110001.63579295@endymion> (raw)
In-Reply-To: <20210225115338.1331-1-zuoqilin1@163.com>
Hi zuoqilin,
There's an obvious typo in the subject. Which is kind of ironical
considering the point of your patch.
Also, your patch is driver-specific, so "i2c/busses:" isn't an
appropriate prefix. According to the standard practice for the i2c
subsystem, the proper prefix for the subject would be: "i2c: sis630:".
On Thu, 25 Feb 2021 19:53:38 +0800, zuoqilin1@163.com wrote:
> From: zuoqilin <zuoqilin@yulong.com>
>
> change 'adress' to 'address'
Please start your sentences with a capital and end them with a dot.
>
> Signed-off-by: zuoqilin <zuoqilin@yulong.com>
> ---
> drivers/i2c/busses/i2c-sis630.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-sis630.c b/drivers/i2c/busses/i2c-sis630.c
> index cfb8e04..87d5625 100644
> --- a/drivers/i2c/busses/i2c-sis630.c
> +++ b/drivers/i2c/busses/i2c-sis630.c
> @@ -97,7 +97,7 @@
> module_param(force, bool, 0);
> MODULE_PARM_DESC(force, "Forcibly enable the SIS630. DANGEROUS!");
>
> -/* SMBus base adress */
> +/* SMBus base address */
> static unsigned short smbus_base;
>
> /* supported chips */
Other than that, the change looks OK, thanks.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2021-02-27 10:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 11:53 [PATCH] i2c/busses: fix spellint typo zuoqilin1
2021-02-27 10:00 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210227110001.63579295@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zuoqilin1@163.com \
--cc=zuoqilin@yulong.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox