* [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined
@ 2021-09-19 10:08 Morten Linderud
2021-10-02 6:43 ` Wolfram Sang
2021-10-04 18:02 ` Jean Delvare
0 siblings, 2 replies; 3+ messages in thread
From: Morten Linderud @ 2021-09-19 10:08 UTC (permalink / raw)
To: linux-i2c; +Cc: Morten Linderud
If we are building to a defined destdir py-smbus is going to ignore this
and try install to the actual root. This breaks packaging setups as the
install section would fail.
Signed-off-by: Morten Linderud <morten@linderud.pw>
---
py-smbus/Module.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/py-smbus/Module.mk b/py-smbus/Module.mk
index 04ceb64..1e2ded1 100644
--- a/py-smbus/Module.mk
+++ b/py-smbus/Module.mk
@@ -22,7 +22,7 @@ clean-python:
rm -rf py-smbus/build
install-python:
- $(DISTUTILS) install
+ $(DISTUTILS) install --prefix="$(PREFIX)"
all: all-python
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined
2021-09-19 10:08 [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined Morten Linderud
@ 2021-10-02 6:43 ` Wolfram Sang
2021-10-04 18:02 ` Jean Delvare
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-10-02 6:43 UTC (permalink / raw)
To: Morten Linderud, Jean Delvare; +Cc: linux-i2c
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On Sun, Sep 19, 2021 at 12:08:51PM +0200, Morten Linderud wrote:
> If we are building to a defined destdir py-smbus is going to ignore this
> and try install to the actual root. This breaks packaging setups as the
> install section would fail.
>
> Signed-off-by: Morten Linderud <morten@linderud.pw>
Looks good to me, adding Jean.
> ---
> py-smbus/Module.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/py-smbus/Module.mk b/py-smbus/Module.mk
> index 04ceb64..1e2ded1 100644
> --- a/py-smbus/Module.mk
> +++ b/py-smbus/Module.mk
> @@ -22,7 +22,7 @@ clean-python:
> rm -rf py-smbus/build
>
> install-python:
> - $(DISTUTILS) install
> + $(DISTUTILS) install --prefix="$(PREFIX)"
>
> all: all-python
>
> --
> 2.33.0
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined
2021-09-19 10:08 [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined Morten Linderud
2021-10-02 6:43 ` Wolfram Sang
@ 2021-10-04 18:02 ` Jean Delvare
1 sibling, 0 replies; 3+ messages in thread
From: Jean Delvare @ 2021-10-04 18:02 UTC (permalink / raw)
To: Morten Linderud; +Cc: linux-i2c
Hi Morten,
On Sun, 19 Sep 2021 12:08:51 +0200, Morten Linderud wrote:
> If we are building to a defined destdir py-smbus is going to ignore this
> and try install to the actual root. This breaks packaging setups as the
> install section would fail.
>
> Signed-off-by: Morten Linderud <morten@linderud.pw>
> ---
> py-smbus/Module.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/py-smbus/Module.mk b/py-smbus/Module.mk
> index 04ceb64..1e2ded1 100644
> --- a/py-smbus/Module.mk
> +++ b/py-smbus/Module.mk
> @@ -22,7 +22,7 @@ clean-python:
> rm -rf py-smbus/build
>
> install-python:
> - $(DISTUTILS) install
> + $(DISTUTILS) install --prefix="$(PREFIX)"
>
> all: all-python
>
Thanks for catching and fixing this. Applied.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-04 18:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-19 10:08 [PATCH i2c-tools] py-smbus/Module.mk: Install with PREFIX defined Morten Linderud
2021-10-02 6:43 ` Wolfram Sang
2021-10-04 18:02 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox