From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>, linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: i801: Don't read back cleared status in i801_check_pre()
Date: Thu, 9 Dec 2021 14:04:18 +0100 [thread overview]
Message-ID: <20211209140418.253f5f51@endymion> (raw)
In-Reply-To: <YbHJfUk14INERHEB@ninjato>
On Thu, 9 Dec 2021 10:16:45 +0100, Wolfram Sang wrote:
> > As I got some time to think about it, answering myself: I'm fine
> > removing the checks. If we ever hit the problem (unable to clear the
> > error flags), it means that something went wrong _before_, and we must
> > have logged these problems already. As a matter of fact, that was
> > exactly the situation for Felix, the message you want to remove was the
> > 4th error message logged, so in fact it did not really add any value.
>
> May I read this as an ack?
Yes, sorry ^^
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Tested-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2021-12-09 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:53 [PATCH] i2c: i801: Don't read back cleared status in i801_check_pre() Heiner Kallweit
2021-12-03 9:59 ` Jean Delvare
2021-12-03 12:55 ` Heiner Kallweit
2021-12-03 21:25 ` Heiner Kallweit
2021-12-07 14:14 ` Jean Delvare
2021-12-09 9:16 ` Wolfram Sang
2021-12-09 13:04 ` Jean Delvare [this message]
2021-12-09 14:51 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211209140418.253f5f51@endymion \
--to=jdelvare@suse.de \
--cc=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox