From: Wolfram Sang <wsa@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Jean Delvare <jdelvare@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: i801: Don't read back cleared status in i801_check_pre()
Date: Thu, 9 Dec 2021 15:51:28 +0100 [thread overview]
Message-ID: <YbIX8MsNqc1J/nZ6@ninjato> (raw)
In-Reply-To: <f0d7dd91-5b35-d5bb-33b7-dacc632c542a@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 445 bytes --]
On Thu, Dec 02, 2021 at 10:53:05AM +0100, Heiner Kallweit wrote:
> I see no need to read back the registers to verify that the bits
> have actually been cleared. I can't imagine any scenario where
> the bits would remain set after a write to them.
>
> Whilst at it, change involved syslog messages to use pci_dbg() et al.
> to simplify them.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2021-12-09 14:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 9:53 [PATCH] i2c: i801: Don't read back cleared status in i801_check_pre() Heiner Kallweit
2021-12-03 9:59 ` Jean Delvare
2021-12-03 12:55 ` Heiner Kallweit
2021-12-03 21:25 ` Heiner Kallweit
2021-12-07 14:14 ` Jean Delvare
2021-12-09 9:16 ` Wolfram Sang
2021-12-09 13:04 ` Jean Delvare
2021-12-09 14:51 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YbIX8MsNqc1J/nZ6@ninjato \
--to=wsa@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox