From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
kvm@vger.kernel.org, "Rafael J. Wysocki" <rafael@kernel.org>,
linux-iio@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
alsa-devel@alsa-project.org,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Guenter Roeck" <groeck@chromium.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
linux-mtd@lists.infradead.org, linux-i2c@vger.kernel.org,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
linux-phy@lists.infradead.org,
"Oleksij Rempel" <linux@rempel-privat.de>,
"Lee Jones" <lee.jones@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
"Peter Korsgaard" <peter@korsgaard.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Matthias Schiffer" <matthias.schiffer@ew.tq-group.com>,
"Joakim Zhang" <qiangqing.zhang@nxp.com>,
"Kamal Dasu" <kdasu.kdev@gmail.com>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Bartosz Golaszewski" <brgl@bgdev.pl>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Kishon Vijay Abraham I" <kishon@ti.com>,
bcm-kernel-feedback-list@broadcom.com,
linux-serial@vger.kernel.org, "Jakub Kicinski" <kuba@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
platform-driver-x86@vger.kernel.org, linux-pwm@vger.kernel.org,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Corey Minyard" <minyard@acm.org>,
linux-pm@vger.kernel.org, "John Garry" <john.garry@huawei.com>,
"William Breathitt Gray" <vilhelm.gray@gmail.com>,
"Mark Gross" <markgross@kernel.org>,
linux-gpio@vger.kernel.org,
"Alex Williamson" <alex.williamson@redhat.com>,
"Mark Brown" <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
"Eric Auger" <eric.auger@redhat.com>,
"Takashi Iwai" <tiwai@suse.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
openipmi-developer@lists.sourceforge.net,
"Jaroslav Kysela" <perex@perex.cz>,
"Benson Leung" <bleung@chromium.org>,
linux-arm-kernel@lists.infradead.org,
"Sergey Shtylyov" <s.shtylyov@omp.ru>,
"Mun Yew Tham" <mun.yew.tham@intel.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Cornelia Huck" <cohuck@redhat.com>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-spi@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
"Vinod Koul" <vkoul@kernel.org>,
"Zha Qipeng" <qipeng.zha@intel.com>,
"Richard Weinberger" <richard@nod.at>,
"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Brian Norris" <computersforpeace@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v2 1/2] platform: make platform_get_irq_optional() optional
Date: Mon, 14 Feb 2022 15:00:27 +0100 [thread overview]
Message-ID: <20220214140027.npw6ddrxklarb6wp@pengutronix.de> (raw)
In-Reply-To: <CAMuHMdWi8gno_FBbc=AwsdRtDJik8_bANjQrrRtUOOBRjFN=KA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]
Hello Geert,
On Mon, Feb 14, 2022 at 10:01:14AM +0100, Geert Uytterhoeven wrote:
> Also IMHO, the dummy value handling is a red herring. Contrary to
> optional clocks and resets, a missing optional interrupt does not
> always mean there is nothing to do: in case of polling, something
> else must definitely be done.
Note this is exactly why I don't like this change. I'd even go so far
and claim that "a missing optional interrupt hardly ever means there is
nothing to do".
> So even if request_irq() would accept a dummy interrupt zero and just
> do nothing, it would give the false impression that that is all there
> is to do, while an actual check for zero with polling code handling
> may still need to be present, thus leading to more not less bugs.
Yes, a dummy irq value will just not be possible.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-14 14:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220212201631.12648-1-s.shtylyov@omp.ru>
2022-02-12 20:16 ` [PATCH v2 1/2] platform: make platform_get_irq_optional() optional Sergey Shtylyov
2022-02-14 7:13 ` Uwe Kleine-König
2022-02-14 9:01 ` Geert Uytterhoeven
2022-02-14 14:00 ` Uwe Kleine-König [this message]
2022-02-14 10:13 ` Andy Shevchenko
2022-02-14 13:56 ` Uwe Kleine-König
2022-02-14 8:54 ` Geert Uytterhoeven
2022-02-14 10:43 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214140027.npw6ddrxklarb6wp@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=alex.williamson@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=amitk@kernel.org \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bleung@chromium.org \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=cohuck@redhat.com \
--cc=computersforpeace@gmail.com \
--cc=daniel.lezcano@linaro.org \
--cc=davem@davemloft.net \
--cc=eric.auger@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=groeck@chromium.org \
--cc=hdegoede@redhat.com \
--cc=jirislaby@kernel.org \
--cc=john.garry@huawei.com \
--cc=kdasu.kdev@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@rempel-privat.de \
--cc=markgross@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=matthias.schiffer@ew.tq-group.com \
--cc=minyard@acm.org \
--cc=miquel.raynal@bootlin.com \
--cc=mun.yew.tham@intel.com \
--cc=netdev@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=perex@perex.cz \
--cc=peter@korsgaard.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=qipeng.zha@intel.com \
--cc=rafael@kernel.org \
--cc=richard@nod.at \
--cc=rui.zhang@intel.com \
--cc=s.shtylyov@omp.ru \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=ulf.hansson@linaro.org \
--cc=vigneshr@ti.com \
--cc=vilhelm.gray@gmail.com \
--cc=vkoul@kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox