From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@kernel.org>
Cc: Linux I2C <linux-i2c@vger.kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH 1/2] i2c: i801: Drop useless masking in i801_access
Date: Thu, 3 Mar 2022 17:41:02 +0100 [thread overview]
Message-ID: <20220303174102.4e6f7f30@endymion.delvare> (raw)
In-Reply-To: <Yh/d92DazP4LUp7H@ninjato>
Hi Wolfram,
On Wed, 2 Mar 2022 22:13:27 +0100, Wolfram Sang wrote:
> On Tue, Mar 01, 2022 at 05:28:59PM +0100, Jean Delvare wrote:
> > I went all the way back to kernel 2.6.12 and that masking was never
> > needed. I suppose it was there in anticipation of software PEC
> > support, but that was never added to the driver (and never will be,
> > as this is made obsolete by hardware PEC).
> >
> > I'm also removing initialization to 0, which is not needed either,
> > and would prevent the compiler from reporting an actual usage of
> > uninitialized variables.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
>
> Applied to for-next, thanks!
>
> Jean, there are still some patches pending for i801, mainly from Heiner
> and an interesting one from Hector. Do you have time for these?
>
> http://patchwork.ozlabs.org/project/linux-i2c/list/?series=&submitter=&state=&q=i801&archive=&delegate=
Yes, they are on my to-do list and not forgotten. Just I had a fairly
busy January and February. Plus I am currently investigating 2 i2c-i801
issues that have been reported to me privately, and I'd rather get them
fixed first before we continue with driver cleanups.
Stay tuned,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2022-03-03 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 16:28 [PATCH 1/2] i2c: i801: Drop useless masking in i801_access Jean Delvare
2022-03-01 16:39 ` [PATCH 2/2] i2c: i801: Add support for the Process Call command Jean Delvare
2022-03-02 14:12 ` Jarkko Nikula
2022-03-02 13:54 ` [PATCH 1/2] i2c: i801: Drop useless masking in i801_access Jarkko Nikula
2022-03-02 21:12 ` Wolfram Sang
2022-03-02 21:13 ` Wolfram Sang
2022-03-03 16:41 ` Jean Delvare [this message]
2022-03-03 18:22 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220303174102.4e6f7f30@endymion.delvare \
--to=jdelvare@suse.de \
--cc=hkallweit1@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox