From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Jean Delvare <jdelvare@suse.de>, Linux I2C <linux-i2c@vger.kernel.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH 1/2] i2c: i801: Drop useless masking in i801_access
Date: Wed, 2 Mar 2022 15:54:55 +0200 [thread overview]
Message-ID: <89a778ff-039e-bbe9-645d-f049a4aebb00@linux.intel.com> (raw)
In-Reply-To: <20220301172859.5593309a@endymion.delvare>
On 3/1/22 18:28, Jean Delvare wrote:
> I went all the way back to kernel 2.6.12 and that masking was never
> needed. I suppose it was there in anticipation of software PEC
> support, but that was never added to the driver (and never will be,
> as this is made obsolete by hardware PEC).
>
> I'm also removing initialization to 0, which is not needed either,
> and would prevent the compiler from reporting an actual usage of
> uninitialized variables.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> ---
> drivers/i2c/busses/i2c-i801.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
next prev parent reply other threads:[~2022-03-02 13:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 16:28 [PATCH 1/2] i2c: i801: Drop useless masking in i801_access Jean Delvare
2022-03-01 16:39 ` [PATCH 2/2] i2c: i801: Add support for the Process Call command Jean Delvare
2022-03-02 14:12 ` Jarkko Nikula
2022-03-02 13:54 ` Jarkko Nikula [this message]
2022-03-02 21:12 ` [PATCH 1/2] i2c: i801: Drop useless masking in i801_access Wolfram Sang
2022-03-02 21:13 ` Wolfram Sang
2022-03-03 16:41 ` Jean Delvare
2022-03-03 18:22 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=89a778ff-039e-bbe9-645d-f049a4aebb00@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox