* [PATCH 3/9] dt-bindings: i2c: mv64xxx: Add F1C100s compatible string [not found] <20221101141658.3631342-1-andre.przywara@arm.com> @ 2022-11-01 14:16 ` Andre Przywara 2022-11-02 17:28 ` Rob Herring 2022-11-02 20:19 ` Wolfram Sang 2022-11-01 14:16 ` [PATCH 4/9] ARM: dts: suniv: f1c100s: add I2C DT nodes Andre Przywara 1 sibling, 2 replies; 6+ messages in thread From: Andre Przywara @ 2022-11-01 14:16 UTC (permalink / raw) To: Jernej Skrabec, Samuel Holland, Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski Cc: devicetree, linux-sunxi, linux-arm-kernel, Icenowy Zheng, Gregory CLEMENT, linux-i2c The I2C controller IP used in the Allwinner F1C100s series of SoCs is compatible with the ones used in the other Allwinner SoCs. Add an F1C100s specific compatible string to the list of existing names. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml index 93c164aa00daf..984fc1ed3ec6a 100644 --- a/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml +++ b/Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml @@ -19,6 +19,7 @@ properties: - const: allwinner,sun6i-a31-i2c - items: - enum: + - allwinner,suniv-f1c100s-i2c - allwinner,sun8i-a23-i2c - allwinner,sun8i-a83t-i2c - allwinner,sun8i-v536-i2c -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 3/9] dt-bindings: i2c: mv64xxx: Add F1C100s compatible string 2022-11-01 14:16 ` [PATCH 3/9] dt-bindings: i2c: mv64xxx: Add F1C100s compatible string Andre Przywara @ 2022-11-02 17:28 ` Rob Herring 2022-11-02 20:19 ` Wolfram Sang 1 sibling, 0 replies; 6+ messages in thread From: Rob Herring @ 2022-11-02 17:28 UTC (permalink / raw) To: Andre Przywara Cc: Samuel Holland, devicetree, Rob Herring, Chen-Yu Tsai, Krzysztof Kozlowski, Icenowy Zheng, Gregory CLEMENT, linux-i2c, Jernej Skrabec, linux-arm-kernel, linux-sunxi On Tue, 01 Nov 2022 14:16:52 +0000, Andre Przywara wrote: > The I2C controller IP used in the Allwinner F1C100s series of SoCs is > compatible with the ones used in the other Allwinner SoCs. > > Add an F1C100s specific compatible string to the list of existing names. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > Documentation/devicetree/bindings/i2c/marvell,mv64xxx-i2c.yaml | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/9] dt-bindings: i2c: mv64xxx: Add F1C100s compatible string 2022-11-01 14:16 ` [PATCH 3/9] dt-bindings: i2c: mv64xxx: Add F1C100s compatible string Andre Przywara 2022-11-02 17:28 ` Rob Herring @ 2022-11-02 20:19 ` Wolfram Sang 1 sibling, 0 replies; 6+ messages in thread From: Wolfram Sang @ 2022-11-02 20:19 UTC (permalink / raw) To: Andre Przywara Cc: Jernej Skrabec, Samuel Holland, Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski, devicetree, linux-sunxi, linux-arm-kernel, Icenowy Zheng, Gregory CLEMENT, linux-i2c [-- Attachment #1: Type: text/plain, Size: 376 bytes --] On Tue, Nov 01, 2022 at 02:16:52PM +0000, Andre Przywara wrote: > The I2C controller IP used in the Allwinner F1C100s series of SoCs is > compatible with the ones used in the other Allwinner SoCs. > > Add an F1C100s specific compatible string to the list of existing names. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Applied to for-next, thanks! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 4/9] ARM: dts: suniv: f1c100s: add I2C DT nodes [not found] <20221101141658.3631342-1-andre.przywara@arm.com> 2022-11-01 14:16 ` [PATCH 3/9] dt-bindings: i2c: mv64xxx: Add F1C100s compatible string Andre Przywara @ 2022-11-01 14:16 ` Andre Przywara 2022-11-06 8:09 ` Jernej Škrabec 1 sibling, 1 reply; 6+ messages in thread From: Andre Przywara @ 2022-11-01 14:16 UTC (permalink / raw) To: Jernej Skrabec, Samuel Holland, Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski Cc: devicetree, linux-sunxi, linux-arm-kernel, Icenowy Zheng, Gregory CLEMENT, linux-i2c The Allwinner F1C100s series of SoCs contain three I2C controllers compatible to the ones used in other Allwinner SoCs. Add the DT nodes describing the resources of the controllers. I2C1 has only one possible pinmux, so add the pinctrl properties for that already. At least one board connects an on-board I2C chip to PD0/PD12 (I2C0), so include those pins already, to simplify referencing them later. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- arch/arm/boot/dts/suniv-f1c100s.dtsi | 50 ++++++++++++++++++++++++++++ 1 file changed, 50 insertions(+) diff --git a/arch/arm/boot/dts/suniv-f1c100s.dtsi b/arch/arm/boot/dts/suniv-f1c100s.dtsi index d5a6324e76465..2901c586971b4 100644 --- a/arch/arm/boot/dts/suniv-f1c100s.dtsi +++ b/arch/arm/boot/dts/suniv-f1c100s.dtsi @@ -166,6 +166,18 @@ mmc0_pins: mmc0-pins { drive-strength = <30>; }; + /omit-if-no-ref/ + i2c0_pd_pins: i2c0-pd-pins { + pins = "PD0", "PD12"; + function = "i2c0"; + }; + + /omit-if-no-ref/ + i2c1_pins: i2c1-pins { + pins = "PD5", "PD6"; + function = "i2c1"; + }; + spi0_pc_pins: spi0-pc-pins { pins = "PC0", "PC1", "PC2", "PC3"; function = "spi0"; @@ -177,6 +189,44 @@ uart0_pe_pins: uart0-pe-pins { }; }; + i2c0: i2c@1c27000 { + compatible = "allwinner,suniv-f1c100s-i2c", + "allwinner,sun6i-a31-i2c"; + reg = <0x01c27000 0x400>; + interrupts = <7>; + clocks = <&ccu CLK_BUS_I2C0>; + resets = <&ccu RST_BUS_I2C0>; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + }; + + i2c1: i2c@1c27400 { + compatible = "allwinner,suniv-f1c100s-i2c", + "allwinner,sun6i-a31-i2c"; + reg = <0x01c27400 0x400>; + interrupts = <8>; + clocks = <&ccu CLK_BUS_I2C1>; + resets = <&ccu RST_BUS_I2C1>; + pinctrl-names = "default"; + pinctrl-0 = <&i2c1_pins>; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + }; + + i2c2: i2c@1c27800 { + compatible = "allwinner,suniv-f1c100s-i2c", + "allwinner,sun6i-a31-i2c"; + reg = <0x01c27800 0x400>; + interrupts = <9>; + clocks = <&ccu CLK_BUS_I2C2>; + resets = <&ccu RST_BUS_I2C2>; + #address-cells = <1>; + #size-cells = <0>; + status = "disabled"; + }; + timer@1c20c00 { compatible = "allwinner,suniv-f1c100s-timer"; reg = <0x01c20c00 0x90>; -- 2.25.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 4/9] ARM: dts: suniv: f1c100s: add I2C DT nodes 2022-11-01 14:16 ` [PATCH 4/9] ARM: dts: suniv: f1c100s: add I2C DT nodes Andre Przywara @ 2022-11-06 8:09 ` Jernej Škrabec 2022-11-06 23:12 ` Andre Przywara 0 siblings, 1 reply; 6+ messages in thread From: Jernej Škrabec @ 2022-11-06 8:09 UTC (permalink / raw) To: Samuel Holland, Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski, Andre Przywara Cc: devicetree, linux-sunxi, linux-arm-kernel, Icenowy Zheng, Gregory CLEMENT, linux-i2c Dne torek, 01. november 2022 ob 15:16:53 CET je Andre Przywara napisal(a): > The Allwinner F1C100s series of SoCs contain three I2C controllers > compatible to the ones used in other Allwinner SoCs. > > Add the DT nodes describing the resources of the controllers. > I2C1 has only one possible pinmux, so add the pinctrl properties for > that already. > At least one board connects an on-board I2C chip to PD0/PD12 (I2C0), so > include those pins already, to simplify referencing them later. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > --- > arch/arm/boot/dts/suniv-f1c100s.dtsi | 50 ++++++++++++++++++++++++++++ > 1 file changed, 50 insertions(+) > > diff --git a/arch/arm/boot/dts/suniv-f1c100s.dtsi > b/arch/arm/boot/dts/suniv-f1c100s.dtsi index d5a6324e76465..2901c586971b4 > 100644 > --- a/arch/arm/boot/dts/suniv-f1c100s.dtsi > +++ b/arch/arm/boot/dts/suniv-f1c100s.dtsi > @@ -166,6 +166,18 @@ mmc0_pins: mmc0-pins { > drive-strength = <30>; > }; > > + /omit-if-no-ref/ > + i2c0_pd_pins: i2c0-pd-pins { > + pins = "PD0", "PD12"; > + function = "i2c0"; > + }; > + > + /omit-if-no-ref/ Above flag is meaningless if i2c1_pins is always referenced by i2c1. Anyway, I see in pinctrl driver that there are actually two possible pin assignments for i2c1. One on port D and another on port B. Best regards, Jernej > + i2c1_pins: i2c1-pins { > + pins = "PD5", "PD6"; > + function = "i2c1"; > + }; > + > spi0_pc_pins: spi0-pc-pins { > pins = "PC0", "PC1", "PC2", "PC3"; > function = "spi0"; > @@ -177,6 +189,44 @@ uart0_pe_pins: uart0-pe-pins { > }; > }; > > + i2c0: i2c@1c27000 { > + compatible = "allwinner,suniv-f1c100s-i2c", > + "allwinner,sun6i-a31-i2c"; > + reg = <0x01c27000 0x400>; > + interrupts = <7>; > + clocks = <&ccu CLK_BUS_I2C0>; > + resets = <&ccu RST_BUS_I2C0>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > + i2c1: i2c@1c27400 { > + compatible = "allwinner,suniv-f1c100s-i2c", > + "allwinner,sun6i-a31-i2c"; > + reg = <0x01c27400 0x400>; > + interrupts = <8>; > + clocks = <&ccu CLK_BUS_I2C1>; > + resets = <&ccu RST_BUS_I2C1>; > + pinctrl-names = "default"; > + pinctrl-0 = <&i2c1_pins>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > + i2c2: i2c@1c27800 { > + compatible = "allwinner,suniv-f1c100s-i2c", > + "allwinner,sun6i-a31-i2c"; > + reg = <0x01c27800 0x400>; > + interrupts = <9>; > + clocks = <&ccu CLK_BUS_I2C2>; > + resets = <&ccu RST_BUS_I2C2>; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > timer@1c20c00 { > compatible = "allwinner,suniv-f1c100s- timer"; > reg = <0x01c20c00 0x90>; ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 4/9] ARM: dts: suniv: f1c100s: add I2C DT nodes 2022-11-06 8:09 ` Jernej Škrabec @ 2022-11-06 23:12 ` Andre Przywara 0 siblings, 0 replies; 6+ messages in thread From: Andre Przywara @ 2022-11-06 23:12 UTC (permalink / raw) To: Jernej Škrabec Cc: Samuel Holland, Chen-Yu Tsai, Rob Herring, Krzysztof Kozlowski, devicetree, linux-sunxi, linux-arm-kernel, Icenowy Zheng, Gregory CLEMENT, linux-i2c On Sun, 06 Nov 2022 09:09:17 +0100 Jernej Škrabec <jernej.skrabec@gmail.com> wrote: > Dne torek, 01. november 2022 ob 15:16:53 CET je Andre Przywara napisal(a): > > The Allwinner F1C100s series of SoCs contain three I2C controllers > > compatible to the ones used in other Allwinner SoCs. > > > > Add the DT nodes describing the resources of the controllers. > > I2C1 has only one possible pinmux, so add the pinctrl properties for > > that already. > > At least one board connects an on-board I2C chip to PD0/PD12 (I2C0), so > > include those pins already, to simplify referencing them later. > > > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> > > --- > > arch/arm/boot/dts/suniv-f1c100s.dtsi | 50 ++++++++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/arch/arm/boot/dts/suniv-f1c100s.dtsi > > b/arch/arm/boot/dts/suniv-f1c100s.dtsi index d5a6324e76465..2901c586971b4 > > 100644 > > --- a/arch/arm/boot/dts/suniv-f1c100s.dtsi > > +++ b/arch/arm/boot/dts/suniv-f1c100s.dtsi > > @@ -166,6 +166,18 @@ mmc0_pins: mmc0-pins { > > drive-strength = <30>; > > }; > > > > + /omit-if-no-ref/ > > + i2c0_pd_pins: i2c0-pd-pins { > > + pins = "PD0", "PD12"; > > + function = "i2c0"; > > + }; > > + > > + /omit-if-no-ref/ > > Above flag is meaningless if i2c1_pins is always referenced by i2c1. Indeed, good point. > Anyway, I > see in pinctrl driver that there are actually two possible pin assignments for > i2c1. One on port D and another on port B. Ah, those are the pins that are not documented in the manual (which is where I looked at). I will drop that node. Cheers, Andre > > Best regards, > Jernej > > > + i2c1_pins: i2c1-pins { > > + pins = "PD5", "PD6"; > > + function = "i2c1"; > > + }; > > + > > spi0_pc_pins: spi0-pc-pins { > > pins = "PC0", "PC1", "PC2", > "PC3"; > > function = "spi0"; > > @@ -177,6 +189,44 @@ uart0_pe_pins: uart0-pe-pins { > > }; > > }; > > > > + i2c0: i2c@1c27000 { > > + compatible = "allwinner,suniv-f1c100s-i2c", > > + "allwinner,sun6i-a31-i2c"; > > + reg = <0x01c27000 0x400>; > > + interrupts = <7>; > > + clocks = <&ccu CLK_BUS_I2C0>; > > + resets = <&ccu RST_BUS_I2C0>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > + i2c1: i2c@1c27400 { > > + compatible = "allwinner,suniv-f1c100s-i2c", > > + "allwinner,sun6i-a31-i2c"; > > + reg = <0x01c27400 0x400>; > > + interrupts = <8>; > > + clocks = <&ccu CLK_BUS_I2C1>; > > + resets = <&ccu RST_BUS_I2C1>; > > + pinctrl-names = "default"; > > + pinctrl-0 = <&i2c1_pins>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > + i2c2: i2c@1c27800 { > > + compatible = "allwinner,suniv-f1c100s-i2c", > > + "allwinner,sun6i-a31-i2c"; > > + reg = <0x01c27800 0x400>; > > + interrupts = <9>; > > + clocks = <&ccu CLK_BUS_I2C2>; > > + resets = <&ccu RST_BUS_I2C2>; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + status = "disabled"; > > + }; > > + > > timer@1c20c00 { > > compatible = "allwinner,suniv-f1c100s- > timer"; > > reg = <0x01c20c00 0x90>; > > > > > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-06 23:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221101141658.3631342-1-andre.przywara@arm.com>
2022-11-01 14:16 ` [PATCH 3/9] dt-bindings: i2c: mv64xxx: Add F1C100s compatible string Andre Przywara
2022-11-02 17:28 ` Rob Herring
2022-11-02 20:19 ` Wolfram Sang
2022-11-01 14:16 ` [PATCH 4/9] ARM: dts: suniv: f1c100s: add I2C DT nodes Andre Przywara
2022-11-06 8:09 ` Jernej Škrabec
2022-11-06 23:12 ` Andre Przywara
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox