From: Mark Hasemeyer <markhas@chromium.org>
To: jsd@semihalf.com
Cc: andriy.shevchenko@linux.intel.com, jarkko.nikula@linux.intel.com,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
mario.limonciello@amd.com, rrangel@chromium.org,
upstream@semihalf.com, wsa@kernel.org, dabros@google.com
Subject: [PATCH -next 2/2] i2c: designware: Add support for new SoCs in AMDPSP driver
Date: Fri, 17 Mar 2023 13:18:34 -0600 [thread overview]
Message-ID: <20230317191834.186690-1-markhas@chromium.org> (raw)
In-Reply-To: <20220916131854.687371-3-jsd@semihalf.com>
- /* Status field in command-response buffer is updated by PSP */
- status = READ_ONCE(req->hdr.status);
+ if (req) {
+ /* Status field in command-response buffer is updated by PSP */
+ status = READ_ONCE(req->hdr.status);
+ } else {
+ status = psp_smn_read(PSP_MBOX_CMD_OFFSET, &status);
+ status &= ~PSP_MBOX_FIELDS_READY;
+ }
The value of the mbox cmd register is getting clobbered by the return value
from psp_smn_read. This can cause bus arbitration to fail as the driver will
think it can grab the bus when it's actually in use by the PSP.
next prev parent reply other threads:[~2023-03-17 19:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 13:18 [PATCH -next 0/2] Add i2c arbitration support for new SoCs Jan Dabros
2022-09-16 13:18 ` [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access Jan Dabros
2022-09-16 17:38 ` Limonciello, Mario
2022-09-20 16:24 ` Jan Dąbroś
2022-09-21 20:12 ` Borislav Petkov
2022-09-21 20:19 ` Limonciello, Mario
2022-09-21 20:50 ` Borislav Petkov
2022-09-22 9:49 ` Andy Shevchenko
2022-09-22 9:51 ` Andy Shevchenko
2022-09-22 13:48 ` Hans de Goede
2022-09-22 14:04 ` Borislav Petkov
2022-09-22 14:29 ` Hans de Goede
2022-09-26 12:49 ` Jan Dąbroś
2022-09-26 14:44 ` Borislav Petkov
2022-10-28 8:32 ` Jan Dąbroś
2023-01-09 11:12 ` Borislav Petkov
2023-01-09 17:10 ` Limonciello, Mario
2023-01-16 10:19 ` Jan Dąbroś
2023-01-16 12:38 ` Andy Shevchenko
2023-01-16 16:22 ` Limonciello, Mario
2023-01-16 17:48 ` Andy Shevchenko
2023-01-16 17:54 ` Andy Shevchenko
2023-01-16 21:59 ` Borislav Petkov
2022-09-19 13:59 ` Andy Shevchenko
2022-09-20 16:27 ` Jan Dąbroś
2022-09-16 13:18 ` [PATCH -next 2/2] i2c: designware: Add support for new SoCs in AMDPSP driver Jan Dabros
2022-09-19 13:59 ` Andy Shevchenko
2023-03-17 19:18 ` Mark Hasemeyer [this message]
2023-03-20 0:16 ` Mario Limonciello
2022-09-19 13:59 ` [PATCH -next 0/2] Add i2c arbitration support for new SoCs Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230317191834.186690-1-markhas@chromium.org \
--to=markhas@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dabros@google.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=rrangel@chromium.org \
--cc=upstream@semihalf.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox