From: Borislav Petkov <bp@alien8.de>
To: "Jan Dąbroś" <jsd@semihalf.com>,
"Limonciello, Mario" <mario.limonciello@amd.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
jarkko.nikula@linux.intel.com, wsa@kernel.org,
rrangel@chromium.org, upstream@semihalf.com,
Muralidhara M K <muralimk@amd.com>,
Naveen Krishna Chatradhi <nchatrad@amd.com>,
Yazen Ghannam <yazen.ghannam@amd.com>
Subject: Re: [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access
Date: Mon, 16 Jan 2023 22:59:41 +0100 [thread overview]
Message-ID: <Y8XIri8/C1ITvDVu@zn.tnic> (raw)
In-Reply-To: <CAOtMz3PG4nku-O7dh+1U_DA05HAmQboTqwUQkCkrXQLV9bFjPw@mail.gmail.com>
On Mon, Jan 16, 2023 at 11:19:00AM +0100, Jan Dąbroś wrote:
> It's not enough for running init_amd_nbs() to have only
> pci_arch_init() done. We need the pci bus to be created and registered
> with all devices found on the bus.
And when is that done and ready? pci_scan_bus()?
Lemme see if I understand the ordering correctly:
1. PCI needs to be initialized and all devices on the bus registered
2. AMD NB needs to run and enumerate the NBs so that the SMN access which you
need, can work.
3. acpi_scan_init()
4. i2c-designware-platdrv registration
Close?
Now, Mario, remind me again, pls, why can't they use the MSR to get the PSP MMIO
base. It has changed but why?
Maybe we should talk offlist first.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2023-01-16 21:59 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 13:18 [PATCH -next 0/2] Add i2c arbitration support for new SoCs Jan Dabros
2022-09-16 13:18 ` [PATCH -next 1/2] i2c: designware: Switch from using MMIO access to SMN access Jan Dabros
2022-09-16 17:38 ` Limonciello, Mario
2022-09-20 16:24 ` Jan Dąbroś
2022-09-21 20:12 ` Borislav Petkov
2022-09-21 20:19 ` Limonciello, Mario
2022-09-21 20:50 ` Borislav Petkov
2022-09-22 9:49 ` Andy Shevchenko
2022-09-22 9:51 ` Andy Shevchenko
2022-09-22 13:48 ` Hans de Goede
2022-09-22 14:04 ` Borislav Petkov
2022-09-22 14:29 ` Hans de Goede
2022-09-26 12:49 ` Jan Dąbroś
2022-09-26 14:44 ` Borislav Petkov
2022-10-28 8:32 ` Jan Dąbroś
2023-01-09 11:12 ` Borislav Petkov
2023-01-09 17:10 ` Limonciello, Mario
2023-01-16 10:19 ` Jan Dąbroś
2023-01-16 12:38 ` Andy Shevchenko
2023-01-16 16:22 ` Limonciello, Mario
2023-01-16 17:48 ` Andy Shevchenko
2023-01-16 17:54 ` Andy Shevchenko
2023-01-16 21:59 ` Borislav Petkov [this message]
2022-09-19 13:59 ` Andy Shevchenko
2022-09-20 16:27 ` Jan Dąbroś
2022-09-16 13:18 ` [PATCH -next 2/2] i2c: designware: Add support for new SoCs in AMDPSP driver Jan Dabros
2022-09-19 13:59 ` Andy Shevchenko
2023-03-17 19:18 ` Mark Hasemeyer
2023-03-20 0:16 ` Mario Limonciello
2022-09-19 13:59 ` [PATCH -next 0/2] Add i2c arbitration support for new SoCs Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y8XIri8/C1ITvDVu@zn.tnic \
--to=bp@alien8.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=muralimk@amd.com \
--cc=nchatrad@amd.com \
--cc=rrangel@chromium.org \
--cc=upstream@semihalf.com \
--cc=wsa@kernel.org \
--cc=yazen.ghannam@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox