Re: [PATCH v6 1/6] usb: Add support for Intel LJCA device

[kernel test robot <lkp@intel.com>]

Hi Ye,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus brgl/gpio/for-next wsa/i2c/for-next broonie-spi/for-next linus/master v6.3-rc3 next-20230323]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Ye-Xiang/usb-Add-support-for-Intel-LJCA-device/20230324-012303
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link:    https://lore.kernel.org/r/20230323172113.1231050-2-xiang.ye%40intel.com
patch subject: [PATCH v6 1/6] usb: Add support for Intel LJCA device
config: riscv-allmodconfig (https://download.01.org/0day-ci/archive/20230324/202303240545.fhNNvhZt-lkp@intel.com/config)
compiler: riscv64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/606c371c73fa37d233b47bd34d4789a1a157a9e4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Ye-Xiang/usb-Add-support-for-Intel-LJCA-device/20230324-012303
        git checkout 606c371c73fa37d233b47bd34d4789a1a157a9e4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/usb/misc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303240545.fhNNvhZt-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/usb/misc/ljca.c:133:9: error: unknown type name 'ljca_event_cb_t'
     133 |         ljca_event_cb_t notify;
         |         ^~~~~~~~~~~~~~~
   drivers/usb/misc/ljca.c: In function 'ljca_stub_notify':
   drivers/usb/misc/ljca.c:252:17: error: called object is not a function or function pointer
     252 |                 stub->event_entry.notify(stub->event_entry.context, cmd, evt_data, len);
         |                 ^~~~
   drivers/usb/misc/ljca.c: In function 'ljca_add_aux_dev':
>> drivers/usb/misc/ljca.c:498:16: error: implicit declaration of function 'acpi_find_child_device'; did you mean 'acpi_match_device'? [-Werror=implicit-function-declaration]
     498 |         adev = acpi_find_child_device(parent, adr, false);
         |                ^~~~~~~~~~~~~~~~~~~~~~
         |                acpi_match_device
>> drivers/usb/misc/ljca.c:498:14: warning: assignment to 'struct acpi_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
     498 |         adev = acpi_find_child_device(parent, adr, false);
         |              ^
>> drivers/usb/misc/ljca.c:479:29: warning: variable 'adev' set but not used [-Wunused-but-set-variable]
     479 |         struct acpi_device *adev = NULL;
         |                             ^~~~
   drivers/usb/misc/ljca.c: At top level:
   drivers/usb/misc/ljca.c:369:12: warning: 'ljca_transfer_internal' defined but not used [-Wunused-function]
     369 | static int ljca_transfer_internal(struct ljca *ljca, u8 cmd, const void *obuf,
         |            ^~~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +498 drivers/usb/misc/ljca.c

   473	
   474	static int ljca_add_aux_dev(struct ljca_dev *dev, char *name, unsigned int id, unsigned int adr,
   475				    void *data)
   476	{
   477		struct auxiliary_device *auxdev;
   478		struct acpi_device *parent;
 > 479		struct acpi_device *adev = NULL;
   480		int ret;
   481	
   482		if (dev->auxdev_count >= ARRAY_SIZE(dev->auxdevs))
   483			return -EINVAL;
   484	
   485		auxdev = &dev->auxdevs[dev->auxdev_count];
   486		auxdev->name = name;
   487		auxdev->id = id;
   488		auxdev->dev.platform_data = data;
   489		auxdev->dev.parent = &dev->intf->dev;
   490		auxdev->dev.release = ljca_aux_release;
   491	
   492		ret = auxiliary_device_init(auxdev);
   493		if (ret)
   494			return ret;
   495	
   496		/* new auxiliary device bind to acpi device */
   497		parent = ACPI_COMPANION(&dev->intf->dev);
 > 498		adev = acpi_find_child_device(parent, adr, false);
   499		ACPI_COMPANION_SET(&auxdev->dev, adev ?: parent);
   500	
   501		ret = auxiliary_device_add(auxdev);
   502		if (ret) {
   503			dev_err(&dev->intf->dev, "failed to add auxiliary dev %s.%d\n", name, id);
   504			auxiliary_device_uninit(auxdev);
   505			return ret;
   506		}
   507	
   508		dev->auxdev_count++;
   509	
   510		return 0;
   511	}
   512	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests