From: Andi Shyti <andi.shyti@kernel.org>
To: Ye Xiang <xiang.ye@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Matthias Kaehlcke <mka@chromium.org>, Lee Jones <lee@kernel.org>,
Wolfram Sang <wsa@kernel.org>, Tyrone Ting <kfting@nuvoton.com>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-gpio@vger.kernel.org, srinivas.pandruvada@intel.com,
heikki.krogerus@linux.intel.com,
andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
zhifeng.wang@intel.com, wentong.wu@intel.com,
lixu.zhang@intel.com
Subject: Re: [PATCH v6 1/6] usb: Add support for Intel LJCA device
Date: Sun, 26 Mar 2023 17:02:25 +0200 [thread overview]
Message-ID: <20230326150225.p5m4fxcwmhwdmtd3@intel.intel> (raw)
In-Reply-To: <20230323172113.1231050-2-xiang.ye@intel.com>
Hi Ye,
> +static void ljca_read_complete(struct urb *urb)
> +{
> + struct ljca_msg *header = urb->transfer_buffer;
> + struct ljca_dev *dev = urb->context;
> + int len = urb->actual_length;
> + int ret;
> +
> + WARN_ON_ONCE(!dev);
> + WARN_ON_ONCE(!header);
WARN_* macros should be used when we can recover from that
condition, while we are running straight to a NULL pointer
dereference.
If !dev or !header is not a warning but a "bug", so either you
make sure we don't go ahead or remove the check.
The rest looks fairly good,
Andi
next prev parent reply other threads:[~2023-03-26 15:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-23 17:21 [PATCH v6 0/6] Add Intel LJCA device driver Ye Xiang
2023-03-23 17:21 ` [PATCH v6 1/6] usb: Add support for Intel LJCA device Ye Xiang
2023-03-23 18:05 ` Greg Kroah-Hartman
2023-03-23 18:44 ` Ye, Xiang
2023-03-23 21:59 ` kernel test robot
2023-03-26 15:02 ` Andi Shyti [this message]
2023-03-23 17:21 ` [PATCH v6 2/6] usb: ljca: Add transport interfaces for sub-module drivers Ye Xiang
2023-03-26 15:18 ` Andi Shyti
2023-03-23 17:21 ` [PATCH v6 3/6] Documentation: Add ABI doc for attributes of LJCA device Ye Xiang
2023-03-23 17:21 ` [PATCH v6 4/6] gpio: Add support for Intel LJCA USB GPIO driver Ye Xiang
2023-03-23 17:21 ` [PATCH v6 5/6] i2c: Add support for Intel LJCA USB I2C driver Ye Xiang
2023-03-26 15:38 ` Andi Shyti
2023-04-10 9:22 ` Ye, Xiang
2023-03-23 17:21 ` [PATCH v6 6/6] spi: Add support for Intel LJCA USB SPI driver Ye Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230326150225.p5m4fxcwmhwdmtd3@intel.intel \
--to=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kfting@nuvoton.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=mka@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@intel.com \
--cc=wentong.wu@intel.com \
--cc=wsa@kernel.org \
--cc=xiang.ye@intel.com \
--cc=zhifeng.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox