From: Nishanth Menon <nm@ti.com>
To: Francesco Dolcini <francesco@dolcini.it>
Cc: Benjamin Bara <bbara93@gmail.com>, Wolfram Sang <wsa@kernel.org>,
Lee Jones <lee@kernel.org>, <rafael.j.wysocki@intel.com>,
<dmitry.osipenko@collabora.com>, <peterz@infradead.org>,
<jonathanh@nvidia.com>, <richard.leitner@linux.dev>,
<treding@nvidia.com>, <linux-kernel@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
Benjamin Bara <benjamin.bara@skidata.com>,
<stable@vger.kernel.org>
Subject: Re: [PATCH v6 1/5] kernel/reboot: emergency_restart: set correct system_state
Date: Thu, 15 Jun 2023 09:39:09 -0500 [thread overview]
Message-ID: <20230615143909.fjr25wghwrtepk6g@unwieldy> (raw)
In-Reply-To: <ZIsQPutiZWACawec@francesco-nb.int.toradex.com>
On 15:21-20230615, Francesco Dolcini wrote:
> > >
> > > --
> > > 2.34.1
> > >
> >
> > Tested-by: Nishanth Menon <nm@ti.com>
> >
> > This in addition to a deeper bug in our driver seems to have helped
> > resolve a report we had been looking at. Tested on beagleplay platform
> >
> > https://lore.kernel.org/all/ZGeHMjlnob2GFyHF@francesco-nb.int.toradex.com/
>
> Is this patch going to fix the RCU warning I reported on that email or
> it is just part of a more complex solution?
From what I see, It is part of the solution.
Problem happens as follows for us:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/firmware/ti_sci.c#n421
When i2c is not that frequently used, runtime pm disables the power
domain on our platform. As part of reset or power-off, when i2c is
invoked, it ends up calling into the firmware handler which (no
surprise), attempts to do the wrong thing (and rightly flagged by RCU).
We are in the middle of trying various combinations out to ensure we
are'nt messing things up.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2023-06-15 14:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-09 19:02 [PATCH v6 0/5] mfd: tps6586x: register restart handler Benjamin Bara
2023-05-09 19:02 ` [PATCH v6 1/5] kernel/reboot: emergency_restart: set correct system_state Benjamin Bara
2023-05-18 11:34 ` Dmitry Osipenko
2023-06-15 0:06 ` Nishanth Menon
2023-06-15 13:21 ` Francesco Dolcini
2023-06-15 14:39 ` Nishanth Menon [this message]
2023-05-09 19:03 ` [PATCH v6 2/5] i2c: core: run atomic i2c xfer when !preemptible Benjamin Bara
2023-05-18 11:34 ` Dmitry Osipenko
2023-06-15 0:05 ` Nishanth Menon
2023-05-09 19:03 ` [PATCH v6 3/5] kernel/reboot: add device to sys_off_handler Benjamin Bara
2023-05-18 11:39 ` Dmitry Osipenko
2023-05-09 19:03 ` [PATCH v6 4/5] mfd: tps6586x: use devm-based power off handler Benjamin Bara
2023-05-18 9:43 ` Lee Jones
2023-05-18 11:15 ` Benjamin Bara
2023-05-18 11:40 ` Dmitry Osipenko
2023-05-09 19:03 ` [PATCH v6 5/5] mfd: tps6586x: register restart handler Benjamin Bara
2023-05-18 9:44 ` Lee Jones
2023-05-18 11:48 ` Dmitry Osipenko
2023-07-12 3:40 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230615143909.fjr25wghwrtepk6g@unwieldy \
--to=nm@ti.com \
--cc=bbara93@gmail.com \
--cc=benjamin.bara@skidata.com \
--cc=dmitry.osipenko@collabora.com \
--cc=francesco@dolcini.it \
--cc=jonathanh@nvidia.com \
--cc=lee@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=richard.leitner@linux.dev \
--cc=stable@vger.kernel.org \
--cc=treding@nvidia.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox