public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Wolfram Sang <wsa@kernel.org>,
	Alexey Khoroshilov <khoroshilov@ispras.ru>,
	Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: hix5hd2: Make sure clk is disabled in remove
Date: Fri, 23 Jun 2023 13:38:40 +0200	[thread overview]
Message-ID: <20230623113840.hakkqj5ehxh53rad@intel.intel> (raw)
In-Reply-To: <ZJVvf1vxqeeq+UHW@shikoro>

Hi Wolfram,

On Fri, Jun 23, 2023 at 12:10:07PM +0200, Wolfram Sang wrote:
> On Fri, Jun 09, 2023 at 12:55:13AM +0200, Andi Shyti wrote:
> > From: Alexey Khoroshilov <khoroshilov@ispras.ru>
> > 
> > pm_runtime_set_suspended() does not lead to call of suspend callback,
> > so clk may be left undisabled in hix5hd2_i2c_remove().
> > 
> > By the way, the patch adds error handling for clk_prepare_enable().
> > 
> > Found by Linux Driver Verification project (linuxtesting.org).
> > 
> > Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> > Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
> 
> I have now applied "[PATCH 05/15] i2c: busses: hix5hd2: Use
> devm_clk_get_enabled()". Can this patch then be dropped entirely?

yes, this patch can be dropped. When I resent this I didn't plan
that refactoring.

Thanks,
Andi

      reply	other threads:[~2023-06-23 11:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-08 22:55 [PATCH v2] i2c: hix5hd2: Make sure clk is disabled in remove Andi Shyti
2023-06-08 23:10 ` Andi Shyti
2023-06-08 23:31   ` Alexey Khoroshilov
2023-06-23 10:10 ` Wolfram Sang
2023-06-23 11:38   ` Andi Shyti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230623113840.hakkqj5ehxh53rad@intel.intel \
    --to=andi.shyti@kernel.org \
    --cc=khoroshilov@ispras.ru \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox