From: Wolfram Sang <wsa@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
Linux I2C <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: hix5hd2: Make sure clk is disabled in remove
Date: Fri, 23 Jun 2023 12:10:07 +0200 [thread overview]
Message-ID: <ZJVvf1vxqeeq+UHW@shikoro> (raw)
In-Reply-To: <20230608225513.1151574-1-andi.shyti@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 643 bytes --]
On Fri, Jun 09, 2023 at 12:55:13AM +0200, Andi Shyti wrote:
> From: Alexey Khoroshilov <khoroshilov@ispras.ru>
>
> pm_runtime_set_suspended() does not lead to call of suspend callback,
> so clk may be left undisabled in hix5hd2_i2c_remove().
>
> By the way, the patch adds error handling for clk_prepare_enable().
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
I have now applied "[PATCH 05/15] i2c: busses: hix5hd2: Use
devm_clk_get_enabled()". Can this patch then be dropped entirely?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-06-23 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 22:55 [PATCH v2] i2c: hix5hd2: Make sure clk is disabled in remove Andi Shyti
2023-06-08 23:10 ` Andi Shyti
2023-06-08 23:31 ` Alexey Khoroshilov
2023-06-23 10:10 ` Wolfram Sang [this message]
2023-06-23 11:38 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZJVvf1vxqeeq+UHW@shikoro \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox