public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Liao Chang <liaochang1@huawei.com>
To: <andi.shyti@kernel.org>, <florian.fainelli@broadcom.com>,
	<rjui@broadcom.com>, <sbranden@broadcom.com>,
	<bcm-kernel-feedback-list@broadcom.com>,
	<yangyicong@hisilicon.com>, <aisheng.dong@nxp.com>,
	<shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
	<kernel@pengutronix.de>, <festevam@gmail.com>,
	<linux-imx@nxp.com>, <kblaiech@nvidia.com>, <asmaa@nvidia.com>,
	<loic.poulain@linaro.org>, <rfoss@kernel.org>, <ardb@kernel.org>,
	<gcherian@marvell.com>
Cc: <linux-i2c@vger.kernel.org>,
	<linux-rpi-kernel@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-arm-msm@vger.kernel.org>, <liaochang1@huawei.com>
Subject: [PATCH 1/9] i2c: bcm2835: Use dev_err_probe in probe function
Date: Fri, 28 Jul 2023 09:31:40 +0800	[thread overview]
Message-ID: <20230728013148.1720978-2-liaochang1@huawei.com> (raw)
In-Reply-To: <20230728013148.1720978-1-liaochang1@huawei.com>

Use the dev_err_probe function instead of dev_err in the probe function
so that the printed messge includes the return value and also handles
-EPROBE_DEFER nicely.

Signed-off-by: Liao Chang <liaochang1@huawei.com>
---
 drivers/i2c/busses/i2c-bcm2835.c | 14 ++++++--------
 1 file changed, 6 insertions(+), 8 deletions(-)

diff --git a/drivers/i2c/busses/i2c-bcm2835.c b/drivers/i2c/busses/i2c-bcm2835.c
index 8ce6d3f49551..9af1a68269ab 100644
--- a/drivers/i2c/busses/i2c-bcm2835.c
+++ b/drivers/i2c/busses/i2c-bcm2835.c
@@ -430,10 +430,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
 
 	i2c_dev->bus_clk = bcm2835_i2c_register_div(&pdev->dev, mclk, i2c_dev);
 
-	if (IS_ERR(i2c_dev->bus_clk)) {
-		dev_err(&pdev->dev, "Could not register clock\n");
-		return PTR_ERR(i2c_dev->bus_clk);
-	}
+	if (IS_ERR(i2c_dev->bus_clk))
+		return dev_err_probe(&pdev->dev, PTR_ERR(i2c_dev->bus_clk),
+				     "Could not register clock\n");
 
 	ret = of_property_read_u32(pdev->dev.of_node, "clock-frequency",
 				   &bus_clk_rate);
@@ -444,10 +443,9 @@ static int bcm2835_i2c_probe(struct platform_device *pdev)
 	}
 
 	ret = clk_set_rate_exclusive(i2c_dev->bus_clk, bus_clk_rate);
-	if (ret < 0) {
-		dev_err(&pdev->dev, "Could not set clock frequency\n");
-		return ret;
-	}
+	if (ret < 0)
+		return dev_err_probe(&pdev->dev, ret,
+				     "Could not set clock frequency\n");
 
 	ret = clk_prepare_enable(i2c_dev->bus_clk);
 	if (ret) {
-- 
2.25.1


  reply	other threads:[~2023-07-28  1:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-28  1:31 [PATCH 0/9] Use dev_err_probe in i2c probe function Liao Chang
2023-07-28  1:31 ` Liao Chang [this message]
2023-07-28 15:53   ` [PATCH 1/9] i2c: bcm2835: Use dev_err_probe in " Florian Fainelli
2023-07-28  1:31 ` [PATCH 2/9] i2c: mlxbf: " Liao Chang
2023-08-01 21:33   ` Andi Shyti
2023-07-28  1:31 ` [PATCH 3/9] i2c: xlp9xx: " Liao Chang
2023-08-01 21:35   ` Andi Shyti
2023-07-28  1:31 ` [PATCH 4/9] i2c: hisi: " Liao Chang
2023-08-01 13:11   ` Yicong Yang
2023-07-28  1:31 ` [PATCH 5/9] i2c: qcom-cci: " Liao Chang
2023-08-01 21:38   ` Andi Shyti
2023-08-18 11:06   ` Dmitry Baryshkov
2023-08-21 20:37     ` Harshit Mogalapalli
2023-08-21 23:08       ` Dmitry Baryshkov
2023-07-28  1:31 ` [PATCH 6/9] i2c: pxa: " Liao Chang
2023-08-01 21:40   ` Andi Shyti
2023-07-28  1:31 ` [PATCH 7/9] i2c: dln2: " Liao Chang
2023-08-01 21:41   ` Andi Shyti
2023-07-28  1:31 ` [PATCH 8/9] i2c: imx-lpi2c: " Liao Chang
2023-07-28  5:55   ` Uwe Kleine-König
2023-07-31  2:16     ` Liao, Chang
2023-07-31  7:34       ` Uwe Kleine-König
2023-08-01  1:23         ` Liao, Chang
2023-07-28  1:31 ` [PATCH 9/9] i2c: synquacer: " Liao Chang
2023-08-01 21:44   ` Andi Shyti
2023-08-02  7:03     ` Liao, Chang
  -- strict thread matches above, loose matches on Subject: below --
2023-08-02  9:57 [PATCH v2 0/9] Use dev_err_probe in i2c " Liao Chang
2023-08-02  9:57 ` [PATCH 1/9] i2c: bcm2835: Use dev_err_probe in " Liao Chang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230728013148.1720978-2-liaochang1@huawei.com \
    --to=liaochang1@huawei.com \
    --cc=aisheng.dong@nxp.com \
    --cc=andi.shyti@kernel.org \
    --cc=ardb@kernel.org \
    --cc=asmaa@nvidia.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=festevam@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=gcherian@marvell.com \
    --cc=kblaiech@nvidia.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=loic.poulain@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=rjui@broadcom.com \
    --cc=s.hauer@pengutronix.de \
    --cc=sbranden@broadcom.com \
    --cc=shawnguo@kernel.org \
    --cc=yangyicong@hisilicon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox