From: Liao Chang <liaochang1@huawei.com>
To: <andi.shyti@kernel.org>, <florian.fainelli@broadcom.com>,
<rjui@broadcom.com>, <sbranden@broadcom.com>,
<bcm-kernel-feedback-list@broadcom.com>,
<yangyicong@hisilicon.com>, <aisheng.dong@nxp.com>,
<shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
<kernel@pengutronix.de>, <festevam@gmail.com>,
<linux-imx@nxp.com>, <kblaiech@nvidia.com>, <asmaa@nvidia.com>,
<loic.poulain@linaro.org>, <rfoss@kernel.org>, <ardb@kernel.org>,
<gcherian@marvell.com>
Cc: <linux-i2c@vger.kernel.org>,
<linux-rpi-kernel@lists.infradead.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>, <liaochang1@huawei.com>
Subject: [PATCH 6/9] i2c: pxa: Use dev_err_probe in probe function
Date: Fri, 28 Jul 2023 09:31:45 +0800 [thread overview]
Message-ID: <20230728013148.1720978-7-liaochang1@huawei.com> (raw)
In-Reply-To: <20230728013148.1720978-1-liaochang1@huawei.com>
Use the dev_err_probe function instead of dev_err in the probe function
so that the printed messge includes the return value and also handles
-EPROBE_DEFER nicely.
Signed-off-by: Liao Chang <liaochang1@huawei.com>
---
drivers/i2c/busses/i2c-pxa.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c
index 937f7eebe906..79df4da0166e 100644
--- a/drivers/i2c/busses/i2c-pxa.c
+++ b/drivers/i2c/busses/i2c-pxa.c
@@ -1404,10 +1404,9 @@ static int i2c_pxa_probe(struct platform_device *dev)
strscpy(i2c->adap.name, "pxa_i2c-i2c", sizeof(i2c->adap.name));
i2c->clk = devm_clk_get(&dev->dev, NULL);
- if (IS_ERR(i2c->clk)) {
- dev_err(&dev->dev, "failed to get the clk: %ld\n", PTR_ERR(i2c->clk));
- return PTR_ERR(i2c->clk);
- }
+ if (IS_ERR(i2c->clk))
+ return dev_err_probe(&dev->dev, PTR_ERR(i2c->clk),
+ "failed to get the clk\n");
i2c->reg_ibmr = i2c->reg_base + pxa_reg_layout[i2c_type].ibmr;
i2c->reg_idbr = i2c->reg_base + pxa_reg_layout[i2c_type].idbr;
--
2.25.1
next prev parent reply other threads:[~2023-07-28 1:32 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 1:31 [PATCH 0/9] Use dev_err_probe in i2c probe function Liao Chang
2023-07-28 1:31 ` [PATCH 1/9] i2c: bcm2835: Use dev_err_probe in " Liao Chang
2023-07-28 15:53 ` Florian Fainelli
2023-07-28 1:31 ` [PATCH 2/9] i2c: mlxbf: " Liao Chang
2023-08-01 21:33 ` Andi Shyti
2023-07-28 1:31 ` [PATCH 3/9] i2c: xlp9xx: " Liao Chang
2023-08-01 21:35 ` Andi Shyti
2023-07-28 1:31 ` [PATCH 4/9] i2c: hisi: " Liao Chang
2023-08-01 13:11 ` Yicong Yang
2023-07-28 1:31 ` [PATCH 5/9] i2c: qcom-cci: " Liao Chang
2023-08-01 21:38 ` Andi Shyti
2023-08-18 11:06 ` Dmitry Baryshkov
2023-08-21 20:37 ` Harshit Mogalapalli
2023-08-21 23:08 ` Dmitry Baryshkov
2023-07-28 1:31 ` Liao Chang [this message]
2023-08-01 21:40 ` [PATCH 6/9] i2c: pxa: " Andi Shyti
2023-07-28 1:31 ` [PATCH 7/9] i2c: dln2: " Liao Chang
2023-08-01 21:41 ` Andi Shyti
2023-07-28 1:31 ` [PATCH 8/9] i2c: imx-lpi2c: " Liao Chang
2023-07-28 5:55 ` Uwe Kleine-König
2023-07-31 2:16 ` Liao, Chang
2023-07-31 7:34 ` Uwe Kleine-König
2023-08-01 1:23 ` Liao, Chang
2023-07-28 1:31 ` [PATCH 9/9] i2c: synquacer: " Liao Chang
2023-08-01 21:44 ` Andi Shyti
2023-08-02 7:03 ` Liao, Chang
-- strict thread matches above, loose matches on Subject: below --
2023-08-02 9:57 [PATCH v2 0/9] Use dev_err_probe in i2c " Liao Chang
2023-08-02 9:57 ` [PATCH 6/9] i2c: pxa: Use dev_err_probe in " Liao Chang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230728013148.1720978-7-liaochang1@huawei.com \
--to=liaochang1@huawei.com \
--cc=aisheng.dong@nxp.com \
--cc=andi.shyti@kernel.org \
--cc=ardb@kernel.org \
--cc=asmaa@nvidia.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=gcherian@marvell.com \
--cc=kblaiech@nvidia.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=loic.poulain@linaro.org \
--cc=rfoss@kernel.org \
--cc=rjui@broadcom.com \
--cc=s.hauer@pengutronix.de \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox