From: Yicong Yang <yangyicong@huawei.com>
To: <wsa@kernel.org>, <andi.shyti@kernel.org>, <linux-i2c@vger.kernel.org>
Cc: <yangyicong@hisilicon.com>, <f.fangjian@huawei.com>,
<linuxarm@huawei.com>
Subject: [PATCH] i2c: hisi: Only handle the interrupt of the driver's transfer
Date: Tue, 1 Aug 2023 20:46:25 +0800 [thread overview]
Message-ID: <20230801124625.63587-1-yangyicong@huawei.com> (raw)
From: Yicong Yang <yangyicong@hisilicon.com>
The controller may be shared with other port, for example the firmware.
Handle the interrupt from other sources will cause crash since some
data are not initialized. So only handle the interrupt of the driver's
transfer and discard others.
Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
---
drivers/i2c/busses/i2c-hisi.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/i2c/busses/i2c-hisi.c b/drivers/i2c/busses/i2c-hisi.c
index e067671b3ce2..8328da4bc3ec 100644
--- a/drivers/i2c/busses/i2c-hisi.c
+++ b/drivers/i2c/busses/i2c-hisi.c
@@ -330,6 +330,14 @@ static irqreturn_t hisi_i2c_irq(int irq, void *context)
struct hisi_i2c_controller *ctlr = context;
u32 int_stat;
+ /*
+ * Don't handle the interrupt if cltr->completion is NULL. We may
+ * reach here because the interrupt is spurious or the transfer is
+ * started by another port rather than us.
+ */
+ if (!ctlr->completion)
+ return IRQ_NONE;
+
int_stat = readl(ctlr->iobase + HISI_I2C_INT_MSTAT);
hisi_i2c_clear_int(ctlr, int_stat);
if (!(int_stat & HISI_I2C_INT_ALL))
--
2.24.0
next reply other threads:[~2023-08-01 12:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 12:46 Yicong Yang [this message]
2023-08-01 22:15 ` [PATCH] i2c: hisi: Only handle the interrupt of the driver's transfer Andi Shyti
2023-08-02 2:39 ` Yicong Yang
2023-08-04 23:30 ` Andi Shyti
2023-08-08 13:11 ` Yicong Yang
2023-08-09 20:08 ` Andi Shyti
2023-08-09 20:43 ` Andi Shyti
2023-08-14 13:42 ` Wolfram Sang
2023-08-15 8:41 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230801124625.63587-1-yangyicong@huawei.com \
--to=yangyicong@huawei.com \
--cc=andi.shyti@kernel.org \
--cc=f.fangjian@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox