From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Wolfram Sang <wsa@kernel.org>, andi.shyti@kernel.org
Cc: Yicong Yang <yangyicong@huawei.com>,
linux-i2c@vger.kernel.org, yangyicong@hisilicon.com,
f.fangjian@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH] i2c: hisi: Only handle the interrupt of the driver's transfer
Date: Tue, 15 Aug 2023 10:41:10 +0200 (CEST) [thread overview]
Message-ID: <344337b8-c0cf-b271-55cc-72c739ab6a4@linux-m68k.org> (raw)
In-Reply-To: <ZNovKVNuxXf457t8@shikoro>
Hi Wolfram, Andi,
On Mon, 14 Aug 2023, Wolfram Sang wrote:
> On Tue, Aug 01, 2023 at 08:46:25PM +0800, Yicong Yang wrote:
>> From: Yicong Yang <yangyicong@hisilicon.com>
>>
>> The controller may be shared with other port, for example the firmware.
>> Handle the interrupt from other sources will cause crash since some
>> data are not initialized. So only handle the interrupt of the driver's
>> transfer and discard others.
>>
>> Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
>
> Applied to for-current, thanks! I updated the comment to mention that
> another port is likely the firmware. Similar like in the above text.
Today's renesas-drivers merge of i2c-host/i2c/andi-for-current got a
conflict in:
drivers/i2c/busses/i2c-hisi.c
between commit fff67c1b17ee0939 ("i2c: hisi: Only handle the interrupt
of the driver's transfer") in i2c/i2c/for-next and commit
9a5adaf694f5ae8b ("i2c: hisi: Only handle the interrupt of the driver's
transfer") in i2c-host/i2c/andi-for-current.
I took the version from i2c/i2c/for-next, as that contained the extra
comment.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
prev parent reply other threads:[~2023-08-15 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 12:46 [PATCH] i2c: hisi: Only handle the interrupt of the driver's transfer Yicong Yang
2023-08-01 22:15 ` Andi Shyti
2023-08-02 2:39 ` Yicong Yang
2023-08-04 23:30 ` Andi Shyti
2023-08-08 13:11 ` Yicong Yang
2023-08-09 20:08 ` Andi Shyti
2023-08-09 20:43 ` Andi Shyti
2023-08-14 13:42 ` Wolfram Sang
2023-08-15 8:41 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=344337b8-c0cf-b271-55cc-72c739ab6a4@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=andi.shyti@kernel.org \
--cc=f.fangjian@huawei.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
--cc=yangyicong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox