From: Andi Shyti <andi.shyti@kernel.org>
To: Hans Hu <HansHu-oc@zhaoxin.com>
Cc: Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org, cobechen@zhaoxin.com,
hanshu@zhaoxin.com
Subject: Re: [RFC] i2c: whether need create *-common.{c,h} for i801 piix4 viapro driver
Date: Thu, 24 Aug 2023 18:57:03 +0200 [thread overview]
Message-ID: <20230824165703.f34girkhqw6vbqsp@intel.intel> (raw)
In-Reply-To: <a74b19fc-1c7d-6e69-1f66-0bf81b4912f0@zhaoxin.com>
Hi Hans,
> Recently I plan to submit one SMBus driver for Zhaoxin platform.
> I studied the existing SMBus drivers, including i2c-viapro.c,
> i2c-i801.c, and i2c-piix4.c. These driver's register layout looks
> similar, and the implementation of their .smbus_xfer callback
> functions is similar too.
>
> Zhaoxin SMBus also uses some of the same design scheme
> (follow VIA's design IP). Then, should I create *-common.{c,h}
> for these dirvers? Or keep the register layout and .smbus_xfer's
> implementation in my own driver? Or any other suggestion?
>
> Look forward to your suggestions!
Sorry for the late reply, I see that you already sent the
patches, will check them.
Andi
prev parent reply other threads:[~2023-08-24 16:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 11:11 [RFC] i2c: whether need create *-common.{c,h} for i801 piix4 viapro driver Hans Hu
2023-08-24 16:57 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230824165703.f34girkhqw6vbqsp@intel.intel \
--to=andi.shyti@kernel.org \
--cc=HansHu-oc@zhaoxin.com \
--cc=cobechen@zhaoxin.com \
--cc=hanshu@zhaoxin.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox