* [RFC] i2c: whether need create *-common.{c,h} for i801 piix4 viapro driver
@ 2023-08-10 11:11 Hans Hu
2023-08-24 16:57 ` Andi Shyti
0 siblings, 1 reply; 2+ messages in thread
From: Hans Hu @ 2023-08-10 11:11 UTC (permalink / raw)
To: Andi Shyti, Wolfram Sang, linux-i2c; +Cc: cobechen, hanshu
Hi Andi, Wolfram,
Recently I plan to submit one SMBus driver for Zhaoxin platform.
I studied the existing SMBus drivers, including i2c-viapro.c,
i2c-i801.c, and i2c-piix4.c. These driver's register layout looks
similar, and the implementation of their .smbus_xfer callback
functions is similar too.
Zhaoxin SMBus also uses some of the same design scheme
(follow VIA's design IP). Then, should I create *-common.{c,h}
for these dirvers? Or keep the register layout and .smbus_xfer's
implementation in my own driver? Or any other suggestion?
Look forward to your suggestions!
Hans,
Thankyou
(I sent this email again because it was rejected by
linux-i2c@vger.kernel.org the first time I sent it.
Please forgive me for being unfamiliar. :)
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RFC] i2c: whether need create *-common.{c,h} for i801 piix4 viapro driver
2023-08-10 11:11 [RFC] i2c: whether need create *-common.{c,h} for i801 piix4 viapro driver Hans Hu
@ 2023-08-24 16:57 ` Andi Shyti
0 siblings, 0 replies; 2+ messages in thread
From: Andi Shyti @ 2023-08-24 16:57 UTC (permalink / raw)
To: Hans Hu; +Cc: Wolfram Sang, linux-i2c, cobechen, hanshu
Hi Hans,
> Recently I plan to submit one SMBus driver for Zhaoxin platform.
> I studied the existing SMBus drivers, including i2c-viapro.c,
> i2c-i801.c, and i2c-piix4.c. These driver's register layout looks
> similar, and the implementation of their .smbus_xfer callback
> functions is similar too.
>
> Zhaoxin SMBus also uses some of the same design scheme
> (follow VIA's design IP). Then, should I create *-common.{c,h}
> for these dirvers? Or keep the register layout and .smbus_xfer's
> implementation in my own driver? Or any other suggestion?
>
> Look forward to your suggestions!
Sorry for the late reply, I see that you already sent the
patches, will check them.
Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-24 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-10 11:11 [RFC] i2c: whether need create *-common.{c,h} for i801 piix4 viapro driver Hans Hu
2023-08-24 16:57 ` Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox