From: Sudeep Holla <sudeep.holla@arm.com>
To: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Andi Shyti <andi.shyti@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: [PATCH 2/3] i2c: xgene-slimpro: Migrate to use generic PCC shmem related macros
Date: Tue, 26 Sep 2023 13:28:01 +0100 [thread overview]
Message-ID: <20230926-pcc_defines-v1-2-0f925a1658fd@arm.com> (raw)
In-Reply-To: <20230926-pcc_defines-v1-0-0f925a1658fd@arm.com>
Use the newly defined common and generic PCC shared memory region
related macros in this driver to replace the locally defined ones.
Cc: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
drivers/i2c/busses/i2c-xgene-slimpro.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/i2c/busses/i2c-xgene-slimpro.c b/drivers/i2c/busses/i2c-xgene-slimpro.c
index fbc1ffbd2fa7..658396c9eeab 100644
--- a/drivers/i2c/busses/i2c-xgene-slimpro.c
+++ b/drivers/i2c/busses/i2c-xgene-slimpro.c
@@ -91,14 +91,6 @@
#define SLIMPRO_IIC_MSG_DWORD_COUNT 3
-/* PCC related defines */
-#define PCC_SIGNATURE 0x50424300
-#define PCC_STS_CMD_COMPLETE BIT(0)
-#define PCC_STS_SCI_DOORBELL BIT(1)
-#define PCC_STS_ERR BIT(2)
-#define PCC_STS_PLAT_NOTIFY BIT(3)
-#define PCC_CMD_GENERATE_DB_INT BIT(15)
-
struct slimpro_i2c_dev {
struct i2c_adapter adapter;
struct device *dev;
@@ -160,11 +152,11 @@ static void slimpro_i2c_pcc_rx_cb(struct mbox_client *cl, void *msg)
/* Check if platform sends interrupt */
if (!xgene_word_tst_and_clr(&generic_comm_base->status,
- PCC_STS_SCI_DOORBELL))
+ PCC_STATUS_SCI_DOORBELL))
return;
if (xgene_word_tst_and_clr(&generic_comm_base->status,
- PCC_STS_CMD_COMPLETE)) {
+ PCC_STATUS_CMD_COMPLETE)) {
msg = generic_comm_base + 1;
/* Response message msg[1] contains the return value. */
@@ -186,10 +178,10 @@ static void slimpro_i2c_pcc_tx_prepare(struct slimpro_i2c_dev *ctx, u32 *msg)
cpu_to_le32(PCC_SIGNATURE | ctx->mbox_idx));
WRITE_ONCE(generic_comm_base->command,
- cpu_to_le16(SLIMPRO_MSG_TYPE(msg[0]) | PCC_CMD_GENERATE_DB_INT));
+ cpu_to_le16(SLIMPRO_MSG_TYPE(msg[0]) | PCC_CMD_GENERATE_DB_INTR));
status = le16_to_cpu(READ_ONCE(generic_comm_base->status));
- status &= ~PCC_STS_CMD_COMPLETE;
+ status &= ~PCC_STATUS_CMD_COMPLETE;
WRITE_ONCE(generic_comm_base->status, cpu_to_le16(status));
/* Copy the message to the PCC comm space */
--
2.42.0
next prev parent reply other threads:[~2023-09-26 12:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 12:27 [PATCH 0/3] ACPI: PCC: Define and use the common PCC shared memory regions related macros Sudeep Holla
2023-09-26 12:28 ` [PATCH 1/3] ACPI: PCC: Add PCC shared memory region command and status bitfields Sudeep Holla
2023-09-27 2:07 ` lihuisong (C)
2023-09-27 13:59 ` Sudeep Holla
2023-09-28 3:49 ` lihuisong (C)
2023-09-28 11:11 ` Sudeep Holla
2023-09-28 11:28 ` lihuisong (C)
2023-09-26 12:28 ` Sudeep Holla [this message]
2023-09-26 21:30 ` [PATCH 2/3] i2c: xgene-slimpro: Migrate to use generic PCC shmem related macros Andi Shyti
2023-09-26 12:28 ` [PATCH 3/3] hwmon: (xgene) " Sudeep Holla
2023-09-26 12:42 ` Guenter Roeck
2023-09-27 2:11 ` [PATCH 0/3] ACPI: PCC: Define and use the common PCC shared memory regions " lihuisong (C)
2023-09-27 14:00 ` Sudeep Holla
2023-09-27 14:19 ` Rafael J. Wysocki
2023-09-27 14:45 ` Sudeep Holla
2023-09-27 15:07 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230926-pcc_defines-v1-2-0f925a1658fd@arm.com \
--to=sudeep.holla@arm.com \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox