From: Guenter Roeck <linux@roeck-us.net>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-acpi@vger.kernel.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Andi Shyti <andi.shyti@kernel.org>,
Jean Delvare <jdelvare@suse.com>
Subject: Re: [PATCH 3/3] hwmon: (xgene) Migrate to use generic PCC shmem related macros
Date: Tue, 26 Sep 2023 05:42:16 -0700 [thread overview]
Message-ID: <667915e2-3c3f-4afd-a055-d010d55b741e@roeck-us.net> (raw)
In-Reply-To: <20230926-pcc_defines-v1-3-0f925a1658fd@arm.com>
On Tue, Sep 26, 2023 at 01:28:02PM +0100, Sudeep Holla wrote:
> Use the newly defined common and generic PCC shared memory region
> related macros in this driver to replace the locally defined ones.
>
> Cc: Jean Delvare <jdelvare@suse.com>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/xgene-hwmon.c | 16 +++++-----------
> 1 file changed, 5 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/hwmon/xgene-hwmon.c b/drivers/hwmon/xgene-hwmon.c
> index 78d9f52e2a71..1ccdd61b6d13 100644
> --- a/drivers/hwmon/xgene-hwmon.c
> +++ b/drivers/hwmon/xgene-hwmon.c
> @@ -57,12 +57,6 @@
> (MSG_TYPE_SET(MSG_TYPE_PWRMGMT) | \
> MSG_SUBTYPE_SET(hndl) | TPC_CMD_SET(cmd) | type)
>
> -/* PCC defines */
> -#define PCC_SIGNATURE_MASK 0x50424300
> -#define PCCC_GENERATE_DB_INT BIT(15)
> -#define PCCS_CMD_COMPLETE BIT(0)
> -#define PCCS_SCI_DOORBEL BIT(1)
> -#define PCCS_PLATFORM_NOTIFICATION BIT(3)
> /*
> * Arbitrary retries in case the remote processor is slow to respond
> * to PCC commands
> @@ -142,15 +136,15 @@ static int xgene_hwmon_pcc_rd(struct xgene_hwmon_dev *ctx, u32 *msg)
>
> /* Write signature for subspace */
> WRITE_ONCE(generic_comm_base->signature,
> - cpu_to_le32(PCC_SIGNATURE_MASK | ctx->mbox_idx));
> + cpu_to_le32(PCC_SIGNATURE | ctx->mbox_idx));
>
> /* Write to the shared command region */
> WRITE_ONCE(generic_comm_base->command,
> - cpu_to_le16(MSG_TYPE(msg[0]) | PCCC_GENERATE_DB_INT));
> + cpu_to_le16(MSG_TYPE(msg[0]) | PCC_CMD_GENERATE_DB_INTR));
>
> /* Flip CMD COMPLETE bit */
> val = le16_to_cpu(READ_ONCE(generic_comm_base->status));
> - val &= ~PCCS_CMD_COMPLETE;
> + val &= ~PCC_STATUS_CMD_COMPLETE;
> WRITE_ONCE(generic_comm_base->status, cpu_to_le16(val));
>
> /* Copy the message to the PCC comm space */
> @@ -544,7 +538,7 @@ static void xgene_hwmon_pcc_rx_cb(struct mbox_client *cl, void *msg)
> msg = generic_comm_base + 1;
> /* Check if platform sends interrupt */
> if (!xgene_word_tst_and_clr(&generic_comm_base->status,
> - PCCS_SCI_DOORBEL))
> + PCC_STATUS_SCI_DOORBELL))
> return;
>
> /*
> @@ -566,7 +560,7 @@ static void xgene_hwmon_pcc_rx_cb(struct mbox_client *cl, void *msg)
> TPC_CMD(((u32 *)msg)[0]) == TPC_ALARM))) {
> /* Check if platform completes command */
> if (xgene_word_tst_and_clr(&generic_comm_base->status,
> - PCCS_CMD_COMPLETE)) {
> + PCC_STATUS_CMD_COMPLETE)) {
> ctx->sync_msg.msg = ((u32 *)msg)[0];
> ctx->sync_msg.param1 = ((u32 *)msg)[1];
> ctx->sync_msg.param2 = ((u32 *)msg)[2];
>
> --
> 2.42.0
>
next prev parent reply other threads:[~2023-09-26 12:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 12:27 [PATCH 0/3] ACPI: PCC: Define and use the common PCC shared memory regions related macros Sudeep Holla
2023-09-26 12:28 ` [PATCH 1/3] ACPI: PCC: Add PCC shared memory region command and status bitfields Sudeep Holla
2023-09-27 2:07 ` lihuisong (C)
2023-09-27 13:59 ` Sudeep Holla
2023-09-28 3:49 ` lihuisong (C)
2023-09-28 11:11 ` Sudeep Holla
2023-09-28 11:28 ` lihuisong (C)
2023-09-26 12:28 ` [PATCH 2/3] i2c: xgene-slimpro: Migrate to use generic PCC shmem related macros Sudeep Holla
2023-09-26 21:30 ` Andi Shyti
2023-09-26 12:28 ` [PATCH 3/3] hwmon: (xgene) " Sudeep Holla
2023-09-26 12:42 ` Guenter Roeck [this message]
2023-09-27 2:11 ` [PATCH 0/3] ACPI: PCC: Define and use the common PCC shared memory regions " lihuisong (C)
2023-09-27 14:00 ` Sudeep Holla
2023-09-27 14:19 ` Rafael J. Wysocki
2023-09-27 14:45 ` Sudeep Holla
2023-09-27 15:07 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=667915e2-3c3f-4afd-a055-d010d55b741e@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox