[PATCH v2] i2c: i801: Add lis3lv02d for Dell Precision M6800 v2 Bios: A26

[PATCH v2] i2c: i801: Add lis3lv02d for Dell Precision M6800 v2 Bios: A26

[Patrick Höhn]

Signed-off-by: Patrick Höhn <hoehnp@gmx.de>
---
 drivers/i2c/busses/i2c-i801.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
index 2c36b36d7d51..c1fee2c61da1 100644
--- a/drivers/i2c/busses/i2c-i801.c
+++ b/drivers/i2c/busses/i2c-i801.c
@@ -1231,6 +1231,7 @@ static const struct {
 	 */
 	{ "Latitude 5480",      0x29 },
 	{ "Precision 3540",     0x29 },
+	{ "Precision M6800",    0x29 },
 	{ "Vostro V131",        0x1d },
 	{ "Vostro 5568",        0x29 },
 	{ "XPS 15 7590",        0x29 },
--
2.43.0

Re: [PATCH v2] i2c: i801: Add lis3lv02d for Dell Precision M6800 v2 Bios: A26

[Andi Shyti]

Hi Patrick,

On Thu, Feb 22, 2024 at 10:50:08PM +0100, Patrick Höhn wrote:
> Signed-off-by: Patrick Höhn <hoehnp@gmx.de>

I see that you've fixed almost everything that Paul has
suggested, but please elaborate a bit more in the git commit.

Spend some time adding a description. If you want, you can reply
to this email with the commit log you have in mind, and I can add
it for you, or you can send a v3.

Thank you, Paul, for your excellent review.

Andi

PS: A small nitpick: there's no need to add 'v2' in the title.
    '[PATCH v2]' is sufficient.

> ---
>  drivers/i2c/busses/i2c-i801.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 2c36b36d7d51..c1fee2c61da1 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1231,6 +1231,7 @@ static const struct {
>  	 */
>  	{ "Latitude 5480",      0x29 },
>  	{ "Precision 3540",     0x29 },
> +	{ "Precision M6800",    0x29 },
>  	{ "Vostro V131",        0x1d },
>  	{ "Vostro 5568",        0x29 },
>  	{ "XPS 15 7590",        0x29 },
> --
> 2.43.0
> 

Re: [PATCH v2] i2c: i801: Add lis3lv02d for Dell Precision M6800 v2 Bios: A26

[Patrick Höhn]

Hi Andi,

sorry for the late response. Since it is the first time I am
contributing, please excuse me, if my description still needs
improvement. I can simply describe what I did:

similiarly to what Paul did before, I identified that the M6800 has the
accelerometer installed and verified its address using my running Gentoo
System. Then I was applying the patch to latest kernel and confirmed
that it was booting successfully and the message about a successful
detection was present.

Is this along the lines you expect?

Best Regards,
Patrick
Den 2024-02-22 kl. 23:24, skrev Andi Shyti:
> Hi Patrick,
>
> On Thu, Feb 22, 2024 at 10:50:08PM +0100, Patrick Höhn wrote:
>> Signed-off-by: Patrick Höhn <hoehnp@gmx.de>
>
> I see that you've fixed almost everything that Paul has
> suggested, but please elaborate a bit more in the git commit.
>
> Spend some time adding a description. If you want, you can reply
> to this email with the commit log you have in mind, and I can add
> it for you, or you can send a v3.
>
> Thank you, Paul, for your excellent review.
>
> Andi
>
> PS: A small nitpick: there's no need to add 'v2' in the title.
>      '[PATCH v2]' is sufficient.
>
>> ---
>>   drivers/i2c/busses/i2c-i801.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
>> index 2c36b36d7d51..c1fee2c61da1 100644
>> --- a/drivers/i2c/busses/i2c-i801.c
>> +++ b/drivers/i2c/busses/i2c-i801.c
>> @@ -1231,6 +1231,7 @@ static const struct {
>>   	 */
>>   	{ "Latitude 5480",      0x29 },
>>   	{ "Precision 3540",     0x29 },
>> +	{ "Precision M6800",    0x29 },
>>   	{ "Vostro V131",        0x1d },
>>   	{ "Vostro 5568",        0x29 },
>>   	{ "XPS 15 7590",        0x29 },
>> --
>> 2.43.0
>>