[PATCH] i2c: at91: Fix the functionality flags of the slave-only interface

[PATCH] i2c: at91: Fix the functionality flags of the slave-only interface

[Jean Delvare]

When an I2C adapter acts only as a slave, it should not claim to
support I2C master capabilities.

Fixes: 9d3ca54b550c ("i2c: at91: added slave mode support")
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Juergen Fitschen <me@jue.yt>
Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Cc: Andi Shyti <andi.shyti@kernel.org>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Claudiu Beznea <claudiu.beznea@tuxon.dev>
---
 drivers/i2c/busses/i2c-at91-slave.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- linux-6.9.orig/drivers/i2c/busses/i2c-at91-slave.c
+++ linux-6.9/drivers/i2c/busses/i2c-at91-slave.c
@@ -106,8 +106,7 @@ static int at91_unreg_slave(struct i2c_c
 
 static u32 at91_twi_func(struct i2c_adapter *adapter)
 {
-	return I2C_FUNC_SLAVE | I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL
-		| I2C_FUNC_SMBUS_READ_BLOCK_DATA;
+	return I2C_FUNC_SLAVE;
 }
 
 static const struct i2c_algorithm at91_twi_algorithm_slave = {


-- 
Jean Delvare
SUSE L3 Support

Re: [PATCH] i2c: at91: Fix the functionality flags of the slave-only interface

[Andi Shyti]

Hi

On Fri, 31 May 2024 11:19:14 +0200, Jean Delvare wrote:
> When an I2C adapter acts only as a slave, it should not claim to
> support I2C master capabilities.
> 
> 

Applied to i2c/i2c-host-fixes on

git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git

Thank you,
Andi

Patches applied
===============
[1/1] i2c: at91: Fix the functionality flags of the slave-only interface
      commit: 66b9a4ab75e8ce82faf9ec5344a870c768aeed78