Re: [PATCH v3 3/5] i2c: piix4: Add ACPI support for ASF SMBus device

[kernel test robot <lkp@intel.com>]

Hi Shyam,

kernel test robot noticed the following build errors:

[auto build test ERROR on andi-shyti/i2c/i2c-host]
[also build test ERROR on linus/master v6.11-rc6 next-20240906]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Shyam-Sundar-S-K/i2c-piix4-Allow-more-than-two-algo-selection-for-SMBus/20240906-152430
base:   https://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git i2c/i2c-host
patch link:    https://lore.kernel.org/r/20240906071201.2254354-4-Shyam-sundar.S-k%40amd.com
patch subject: [PATCH v3 3/5] i2c: piix4: Add ACPI support for ASF SMBus device
config: x86_64-buildonly-randconfig-006-20240907 (https://download.01.org/0day-ci/archive/20240907/202409071045.2aUSULRN-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240907/202409071045.2aUSULRN-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409071045.2aUSULRN-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/i2c/busses/i2c-piix4.c: In function 'sb800_asf_add_adap':
   drivers/i2c/busses/i2c-piix4.c:1304:16: error: implicit declaration of function 'acpi_fetch_acpi_dev'; did you mean 'acpi_match_acpi_device'? [-Werror=implicit-function-declaration]
    1304 |         adev = acpi_fetch_acpi_dev(handle);
         |                ^~~~~~~~~~~~~~~~~~~
         |                acpi_match_acpi_device
   drivers/i2c/busses/i2c-piix4.c:1304:14: warning: assignment to 'struct acpi_device *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
    1304 |         adev = acpi_fetch_acpi_dev(handle);
         |              ^
   drivers/i2c/busses/i2c-piix4.c:1309:15: error: implicit declaration of function 'acpi_dev_get_resources'; did you mean 'acpi_get_event_resources'? [-Werror=implicit-function-declaration]
    1309 |         ret = acpi_dev_get_resources(adev, &res_list, NULL, NULL);
         |               ^~~~~~~~~~~~~~~~~~~~~~
         |               acpi_get_event_resources
   In file included from include/linux/device.h:15,
                    from include/linux/pci.h:37,
                    from drivers/i2c/busses/i2c-piix4.c:26:
>> drivers/i2c/busses/i2c-piix4.c:1324:39: error: invalid use of undefined type 'struct acpi_device'
    1324 |                         dev_warn(&adev->dev, "Invalid ASF resource\n");
         |                                       ^~
   include/linux/dev_printk.h:110:25: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                         ^~~
   drivers/i2c/busses/i2c-piix4.c:1324:25: note: in expansion of macro 'dev_warn'
    1324 |                         dev_warn(&adev->dev, "Invalid ASF resource\n");
         |                         ^~~~~~~~
   drivers/i2c/busses/i2c-piix4.c:1329:9: error: implicit declaration of function 'acpi_dev_free_resource_list'; did you mean 'pci_free_resource_list'? [-Werror=implicit-function-declaration]
    1329 |         acpi_dev_free_resource_list(&res_list);
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         |         pci_free_resource_list
   cc1: some warnings being treated as errors


vim +1324 drivers/i2c/busses/i2c-piix4.c

  1288	
  1289	static int sb800_asf_add_adap(struct pci_dev *dev)
  1290	{
  1291		struct i2c_piix4_adapdata *adapdata;
  1292		struct resource_entry *rentry;
  1293		struct sb800_asf_data data;
  1294		struct list_head res_list;
  1295		struct acpi_device *adev;
  1296		acpi_status status;
  1297		acpi_handle handle;
  1298		int ret;
  1299	
  1300		status = acpi_get_handle(NULL, SB800_ASF_ACPI_PATH, &handle);
  1301		if (ACPI_FAILURE(status))
  1302			return -ENODEV;
  1303	
  1304		adev = acpi_fetch_acpi_dev(handle);
  1305		if (!adev)
  1306			return -ENODEV;
  1307	
  1308		INIT_LIST_HEAD(&res_list);
  1309		ret = acpi_dev_get_resources(adev, &res_list, NULL, NULL);
  1310		if (ret < 0) {
  1311			dev_err(&dev->dev, "Error getting ASF ACPI resource: %d\n", ret);
  1312			return ret;
  1313		}
  1314	
  1315		list_for_each_entry(rentry, &res_list, node) {
  1316			switch (resource_type(rentry->res)) {
  1317			case IORESOURCE_IO:
  1318				data.addr = rentry->res->start;
  1319				break;
  1320			case IORESOURCE_IRQ:
  1321				data.irq = rentry->res->start;
  1322				break;
  1323			default:
> 1324				dev_warn(&adev->dev, "Invalid ASF resource\n");
  1325				break;
  1326			}
  1327		}
  1328	
  1329		acpi_dev_free_resource_list(&res_list);
  1330		ret = piix4_add_adapter(dev, data.addr, SMBUS_ASF, piix4_adapter_count, false, 0,
  1331					piix4_main_port_names_sb800[piix4_adapter_count],
  1332					&piix4_main_adapters[piix4_adapter_count]);
  1333		if (ret) {
  1334			dev_err(&dev->dev, "Failed to add ASF adapter: %d\n", ret);
  1335			return -ENODEV;
  1336		}
  1337	
  1338		adapdata = i2c_get_adapdata(piix4_main_adapters[piix4_adapter_count]);
  1339		ret = devm_request_irq(&dev->dev, data.irq, sb800_asf_irq_handler, IRQF_SHARED,
  1340				       "sb800_smbus_asf", adapdata);
  1341		if (ret) {
  1342			dev_err(&dev->dev, "Unable to request irq: %d for use\n", data.irq);
  1343			return ret;
  1344		}
  1345	
  1346		INIT_DELAYED_WORK(&adapdata->work_buf, sb800_asf_process_slave);
  1347		adapdata->is_asf = true;
  1348		/* Increment the adapter count by 1 as ASF is added to the list */
  1349		piix4_adapter_count++;
  1350		return 1;
  1351	}
  1352	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki