[PATCH v2] i2c: qcom-geni: Keep comment why interrupts start disabled

[PATCH v2] i2c: qcom-geni: Keep comment why interrupts start disabled

[Andi Shyti]

From: Wolfram Sang <wsa+renesas@sang-engineering.com>

The to-be-fixed commit rightfully reduced a race window, but also
removed a comment which is still helpful after the fix. Bring the
comment back.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
---
Hi,

I'm resending this patch from Wolfram so that we don't lose it. All the changes
in this v2 have been agreed during code review.

Here's the difference:
v1 -> v2:
 - Reword the comment.
 - Remove the Fixes tag.
 - Add Bjorn's r-b.

 drivers/i2c/busses/i2c-qcom-geni.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index 212336f724a69..b48f25c58baa9 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -818,6 +818,8 @@ static int geni_i2c_probe(struct platform_device *pdev)
 	init_completion(&gi2c->done);
 	spin_lock_init(&gi2c->lock);
 	platform_set_drvdata(pdev, gi2c);
+
+	/* Keep interrupts disabled initially to allow for low-power modes */
 	ret = devm_request_irq(dev, gi2c->irq, geni_i2c_irq, IRQF_NO_AUTOEN,
 			       dev_name(dev), gi2c);
 	if (ret) {
-- 
2.45.2

Re: [PATCH v2] i2c: qcom-geni: Keep comment why interrupts start disabled

[Andi Shyti]

On Tue, Oct 01, 2024 at 03:36:20PM GMT, Andi Shyti wrote:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> The to-be-fixed commit rightfully reduced a race window, but also
> removed a comment which is still helpful after the fix. Bring the
> comment back.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> Reviewed-by: Bjorn Andersson <andersson@kernel.org>
> Signed-off-by: Andi Shyti <andi.shyti@kernel.org>

merged to i2c/i2c-host.

Andi