From: Andi Shyti <andi.shyti@kernel.org>
To: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org
Cc: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
Vladimir Zapolskiy <vz@mleia.com>
Subject: [PATCH v3 0/2] Qcom Geni exit path cleanups
Date: Fri, 27 Dec 2024 23:32:28 +0100 [thread overview]
Message-ID: <20241227223230.462395-1-andi.shyti@kernel.org> (raw)
Hi,
I am submitting two trivial cleanups in this series. The first
replaces all instances of dev_err with dev_err_probe throughout
the probe function for consistency. The second improves the error
exit path by introducing a single 'goto' label for better
maintainability.
Thank you Mukesh and Vladimir for your reviews.
Thank you,
Andi
Changelog:
----------
v2 -> v3:
- Don't forget to assign ret the proper value.
- Add tags in patch 1.
v1 -> v2:
- Updated the final return statement to return 'ret' instead of
'0' for consistency. Since 'ret' already holds the value '0',
this change is purely aesthetic.
- Renamed the exit label from 'err_off' to 'err_resources' for
improved clarity and alignment with its purpose.
Andi Shyti (2):
i2c: qcom-geni: Use dev_err_probe in the probe function
i2c: qcom-geni: Simplify error handling in probe function
drivers/i2c/busses/i2c-qcom-geni.c | 56 ++++++++++++++----------------
1 file changed, 27 insertions(+), 29 deletions(-)
--
2.45.2
next reply other threads:[~2024-12-28 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 22:32 Andi Shyti [this message]
2024-12-27 22:32 ` [PATCH v3 1/2] i2c: qcom-geni: Use dev_err_probe in the probe function Andi Shyti
2024-12-27 22:32 ` [PATCH v3 2/2] i2c: qcom-geni: Simplify error handling in " Andi Shyti
2024-12-28 22:11 ` Vladimir Zapolskiy
2024-12-28 22:13 ` Vladimir Zapolskiy
2024-12-30 2:02 ` [PATCH v3 0/2] Qcom Geni exit path cleanups Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241227223230.462395-1-andi.shyti@kernel.org \
--to=andi.shyti@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=quic_msavaliy@quicinc.com \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox