From: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
To: Andi Shyti <andi.shyti@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org
Cc: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
Subject: Re: [PATCH v3 2/2] i2c: qcom-geni: Simplify error handling in probe function
Date: Sun, 29 Dec 2024 00:13:16 +0200 [thread overview]
Message-ID: <d1254705-6ad7-4e2b-8cfa-57644b32114e@linaro.org> (raw)
In-Reply-To: <20241227223230.462395-3-andi.shyti@kernel.org>
On 12/28/24 00:32, Andi Shyti wrote:
> Avoid repeating the error handling pattern:
>
> geni_se_resources_off(&gi2c->se);
> clk_disable_unprepare(gi2c->core_clk);
> return;
>
> Introduce a single 'goto' exit label for cleanup in case of
> errors. While there are currently two distinct exit points, there
> is no overlap in their handling, allowing both branches to
> coexist cleanly.
>
> Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
--
Best wishes,
Vladimir
next prev parent reply other threads:[~2024-12-28 22:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-27 22:32 [PATCH v3 0/2] Qcom Geni exit path cleanups Andi Shyti
2024-12-27 22:32 ` [PATCH v3 1/2] i2c: qcom-geni: Use dev_err_probe in the probe function Andi Shyti
2024-12-27 22:32 ` [PATCH v3 2/2] i2c: qcom-geni: Simplify error handling in " Andi Shyti
2024-12-28 22:11 ` Vladimir Zapolskiy
2024-12-28 22:13 ` Vladimir Zapolskiy [this message]
2024-12-30 2:02 ` [PATCH v3 0/2] Qcom Geni exit path cleanups Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1254705-6ad7-4e2b-8cfa-57644b32114e@linaro.org \
--to=vladimir.zapolskiy@linaro.org \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=quic_msavaliy@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox