* [PATCH] i2ctransfer: Don't link with libi2c
@ 2025-05-13 11:35 Jean Delvare
2025-05-19 15:18 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2025-05-13 11:35 UTC (permalink / raw)
To: Linux I2C; +Cc: Wolfram Sang
i2ctransfer doesn't make use of any function from libi2c so it should
not link with that library.
Fixes: 9fc53a7fc669 ("i2c-tools: add new tool 'i2ctransfer'")
Signed-off-by: Jean Delvare <jdelvare@suse.de>
---
tools/Module.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- i2c-tools.orig/tools/Module.mk
+++ i2c-tools/tools/Module.mk
@@ -36,8 +36,8 @@ $(TOOLS_DIR)/i2cset: $(TOOLS_DIR)/i2cset
$(TOOLS_DIR)/i2cget: $(TOOLS_DIR)/i2cget.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o $(LIB_DEPS)
$(CC) $(LDFLAGS) -o $@ $^ $(TOOLS_LDFLAGS)
-$(TOOLS_DIR)/i2ctransfer: $(TOOLS_DIR)/i2ctransfer.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o $(LIB_DEPS)
- $(CC) $(LDFLAGS) -o $@ $^ $(TOOLS_LDFLAGS)
+$(TOOLS_DIR)/i2ctransfer: $(TOOLS_DIR)/i2ctransfer.o $(TOOLS_DIR)/i2cbusses.o $(TOOLS_DIR)/util.o
+ $(CC) $(LDFLAGS) -o $@ $^
#
# Objects
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] i2ctransfer: Don't link with libi2c
2025-05-13 11:35 [PATCH] i2ctransfer: Don't link with libi2c Jean Delvare
@ 2025-05-19 15:18 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2025-05-19 15:18 UTC (permalink / raw)
To: Jean Delvare; +Cc: Linux I2C
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
On Tue, May 13, 2025 at 01:35:51PM +0200, Jean Delvare wrote:
> i2ctransfer doesn't make use of any function from libi2c so it should
> not link with that library.
>
> Fixes: 9fc53a7fc669 ("i2c-tools: add new tool 'i2ctransfer'")
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
Applied, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-19 15:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-13 11:35 [PATCH] i2ctransfer: Don't link with libi2c Jean Delvare
2025-05-19 15:18 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox