From: Kartik Rajput <kkartik@nvidia.com>
To: <akhilrajeev@nvidia.com>, <andi.shyti@kernel.org>,
<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<ldewangan@nvidia.com>, <digetx@gmail.com>,
<linux-i2c@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <kkartik@nvidia.com>
Subject: [PATCH v8 1/4] i2c: tegra: Do not configure DMA if not supported
Date: Wed, 17 Sep 2025 14:26:47 +0530 [thread overview]
Message-ID: <20250917085650.594279-2-kkartik@nvidia.com> (raw)
In-Reply-To: <20250917085650.594279-1-kkartik@nvidia.com>
On Tegra264, not all I2C controllers have the necessary interface to
GPC DMA, this causes failures when function tegra_i2c_init_dma()
is called.
Ensure that "dmas" device-tree property is present before initializing
DMA in function tegra_i2c_init_dma().
Signed-off-by: Kartik Rajput <kkartik@nvidia.com>
---
v2 -> v4:
* Add debug print if DMA is not supported by the I2C controller.
v1 -> v2:
* Update commit message to clarify that some I2C controllers may
not have the necessary interface to GPC DMA.
---
drivers/i2c/busses/i2c-tegra.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index e533460bccc3..d908e5e3f0af 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -446,6 +446,11 @@ static int tegra_i2c_init_dma(struct tegra_i2c_dev *i2c_dev)
u32 *dma_buf;
int err;
+ if (!of_property_present(i2c_dev->dev->of_node, "dmas")) {
+ dev_dbg(i2c_dev->dev, "DMA not available, falling back to PIO\n");
+ return 0;
+ }
+
if (IS_VI(i2c_dev))
return 0;
--
2.43.0
next prev parent reply other threads:[~2025-09-17 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-17 8:56 [PATCH v8 0/4] Add I2C support for Tegra264 Kartik Rajput
2025-09-17 8:56 ` Kartik Rajput [this message]
2025-09-17 14:08 ` [PATCH v8 1/4] i2c: tegra: Do not configure DMA if not supported Jon Hunter
2025-09-18 7:10 ` Kartik Rajput
2025-09-17 8:56 ` [PATCH v8 2/4] i2c: tegra: Add HS mode support Kartik Rajput
2025-09-17 13:59 ` Jon Hunter
2025-09-18 10:04 ` Akhil R
2025-09-18 10:21 ` Jon Hunter
2025-09-18 11:16 ` Akhil R
2025-09-18 12:55 ` Jon Hunter
2025-09-18 17:12 ` Akhil R
2025-09-18 17:33 ` Jon Hunter
2025-09-17 8:56 ` [PATCH v8 3/4] i2c: tegra: Add support for SW mutex register Kartik Rajput
2025-09-17 8:56 ` [PATCH v8 4/4] i2c: tegra: Add Tegra264 support Kartik Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250917085650.594279-2-kkartik@nvidia.com \
--to=kkartik@nvidia.com \
--cc=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox