From: Akhil R <akhilrajeev@nvidia.com>
To: <jonathanh@nvidia.com>
Cc: <akhilrajeev@nvidia.com>, <andi.shyti@kernel.org>,
<conor+dt@kernel.org>, <devicetree@vger.kernel.org>,
<digetx@gmail.com>, <kkartik@nvidia.com>, <krzk+dt@kernel.org>,
<ldewangan@nvidia.com>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<robh@kernel.org>, <thierry.reding@gmail.com>
Subject: Re: [PATCH v9 3/4] i2c: tegra: Add support for SW mutex register
Date: Tue, 28 Oct 2025 18:24:49 +0530 [thread overview]
Message-ID: <20251028125449.46934-1-akhilrajeev@nvidia.com> (raw)
In-Reply-To: <96e9898f-e306-4b73-9d06-5515916cd769@nvidia.com>
On Fri, 24 Oct 2025 16:42:06 +0100, Jon Hunter wrote:
> On 01/10/2025 07:47, Kartik Rajput wrote:
>> static void tegra_i2c_mask_irq(struct tegra_i2c_dev *i2c_dev, u32 mask)
>> {
>> u32 int_mask;
>> @@ -1432,6 +1512,10 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
>> return ret;
>> }
>>
>> + ret = tegra_i2c_mutex_lock(i2c_dev);
>> + if (ret)
>> + return ret;
>> +
>>
>> I wonder if it would be better to have a wrapper function around
>> tegra_i2c_xfer() called tegra264_i2c_xfer() that is only used for
>> Tegra264 platforms and invokes these sw-mutex functions?
Wouldn't this only add another 'if' condition to tegra_i2c_xfer()?
And probably making it more complex? Or am I missing something?
Regards,
Akhil
next prev parent reply other threads:[~2025-10-28 12:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 6:47 [PATCH v9 0/4] Add I2C support for Tegra264 Kartik Rajput
2025-10-01 6:47 ` [PATCH v9 1/4] i2c: tegra: Do not configure DMA if not supported Kartik Rajput
2025-10-24 15:20 ` Jon Hunter
2025-10-28 10:00 ` Akhil R
2025-10-28 10:41 ` Jon Hunter
2025-10-28 13:08 ` Akhil R
2025-10-28 16:09 ` Jon Hunter
2025-11-06 15:51 ` Jon Hunter
2025-10-01 6:47 ` [PATCH v9 2/4] i2c: tegra: Add HS mode support Kartik Rajput
2025-10-24 15:28 ` Jon Hunter
2025-11-06 6:17 ` Akhil R
2025-11-06 16:02 ` Jon Hunter
2025-10-01 6:47 ` [PATCH v9 3/4] i2c: tegra: Add support for SW mutex register Kartik Rajput
2025-10-24 15:42 ` Jon Hunter
2025-10-28 12:54 ` Akhil R [this message]
2025-10-28 16:14 ` Jon Hunter
2025-11-06 15:52 ` Jon Hunter
2025-10-01 6:47 ` [PATCH v9 4/4] i2c: tegra: Add Tegra264 support Kartik Rajput
2025-10-24 15:43 ` Jon Hunter
2025-10-21 8:17 ` [PATCH v9 0/4] Add I2C support for Tegra264 Kartik Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251028125449.46934-1-akhilrajeev@nvidia.com \
--to=akhilrajeev@nvidia.com \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=kkartik@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=ldewangan@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox