public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Encrow Thorne <jyc0019@gmail.com>
To: Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	 Andi Shyti <andi.shyti@kernel.org>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	Paul Walmsley <pjw@kernel.org>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Alexandre Ghiti <alex@ghiti.fr>
Cc: Troy Mitchell <troymitchell988@gmail.com>,
	 Guodong Xu <guodong@riscstar.com>,
	linux-i2c@vger.kernel.org,  devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org,  spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org,  Encrow Thorne <jyc0019@gmail.com>
Subject: [PATCH v2 2/3] i2c: k1: add reset support
Date: Fri, 19 Dec 2025 15:42:21 +0800	[thread overview]
Message-ID: <20251219-i2c-reset-v2-2-ad201a602e74@gmail.com> (raw)
In-Reply-To: <20251219-i2c-reset-v2-0-ad201a602e74@gmail.com>

The K1 I2C controller provides a reset line that needs to be deasserted
before the controller can be accessed.

Add reset support to the driver to ensure the controller starts in the
required state.

Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
---
 drivers/i2c/busses/i2c-k1.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c
index d42c03ef5db5..23661c7ddb67 100644
--- a/drivers/i2c/busses/i2c-k1.c
+++ b/drivers/i2c/busses/i2c-k1.c
@@ -10,6 +10,7 @@
  #include <linux/module.h>
  #include <linux/of_address.h>
  #include <linux/platform_device.h>
+ #include <linux/reset.h>
 
 /* spacemit i2c registers */
 #define SPACEMIT_ICR		 0x0		/* Control register */
@@ -534,6 +535,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev)
 	struct device *dev = &pdev->dev;
 	struct device_node *of_node = pdev->dev.of_node;
 	struct spacemit_i2c_dev *i2c;
+	struct reset_control *rst;
 	int ret;
 
 	i2c = devm_kzalloc(dev, sizeof(*i2c), GFP_KERNEL);
@@ -578,6 +580,11 @@ static int spacemit_i2c_probe(struct platform_device *pdev)
 	if (IS_ERR(clk))
 		return dev_err_probe(dev, PTR_ERR(clk), "failed to enable bus clock");
 
+	rst = devm_reset_control_get_optional_exclusive_deasserted(dev, NULL);
+	if (IS_ERR(rst))
+		return dev_err_probe(dev, PTR_ERR(rst),
+				     "failed to acquire deasserted reset\n");
+
 	spacemit_i2c_reset(i2c);
 
 	i2c_set_adapdata(&i2c->adapt, i2c);

-- 
2.25.1


  parent reply	other threads:[~2025-12-19  7:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19  7:42 [PATCH v2 0/3] i2c: spacemit: add reset support Encrow Thorne
2025-12-19  7:42 ` [PATCH v2 1/3] dt-bindings: i2c: spacemit: add optional resets Encrow Thorne
2025-12-19  8:03   ` Krzysztof Kozlowski
2025-12-26  3:25     ` Troy Mitchell
2025-12-19  7:42 ` Encrow Thorne [this message]
2025-12-25 21:01   ` [PATCH v2 2/3] i2c: k1: add reset support Andi Shyti
2025-12-25 23:38     ` Guodong Xu
2025-12-27 19:26       ` Andi Shyti
2025-12-28  0:42         ` Guodong Xu
2025-12-30 14:11           ` Troy Mitchell
2025-12-30 14:14             ` Troy Mitchell
2025-12-26  3:24   ` Troy Mitchell
2025-12-19  7:42 ` [PATCH v2 3/3] riscv: dts: spacemit: add reset property Encrow Thorne
2025-12-19  8:03 ` [PATCH v2 0/3] i2c: spacemit: add reset support Krzysztof Kozlowski
2025-12-27 23:53   ` Guodong Xu
2025-12-30 13:56     ` Encrow Thorne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251219-i2c-reset-v2-2-ad201a602e74@gmail.com \
    --to=jyc0019@gmail.com \
    --cc=alex@ghiti.fr \
    --cc=andi.shyti@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=guodong@riscstar.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    --cc=troy.mitchell@linux.spacemit.com \
    --cc=troymitchell988@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox