public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	Encrow Thorne <jyc0019@gmail.com>,
	Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Paul Walmsley <pjw@kernel.org>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>
Cc: Troy Mitchell <troymitchell988@gmail.com>,
	Guodong Xu <guodong@riscstar.com>,
	linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
	linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: i2c: spacemit: add optional resets
Date: Fri, 26 Dec 2025 11:25:48 +0800	[thread overview]
Message-ID: <65A454B4ACFB1A38+aU4APFpyblOCKqJ4@kernel.org> (raw)
In-Reply-To: <04880c83-0b3a-4197-9043-d657db91f922@kernel.org>

On Fri, Dec 19, 2025 at 09:03:14AM +0100, Krzysztof Kozlowski wrote:
> On 19/12/2025 08:42, Encrow Thorne wrote:
> > The I2C controller requires a reset to ensure it starts from a clean state.
> > 
> > Add the 'resets' property to support this hardware requirement.
> > 
> > Signed-off-by: Encrow Thorne <jyc0019@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> > index b7220fff2235..1290106e28e6 100644
> > --- a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml
> > @@ -32,6 +32,9 @@ properties:
> >        - const: func
> >        - const: bus
> >  
> > +  resets:
> > +    maxItems: 1
> > +
> 
> Still between other clock-related properties. You already got such
> comment...
Please replace it below clock-frequency.
With this fix, you can add my tag:

Reviewed-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> 
> >    clock-frequency:
> >      description: |
> >        K1 support three different modes which running different frequencies
> > 
> 
> 
> Best regards,
> Krzysztof
> 

  reply	other threads:[~2025-12-26  3:27 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-19  7:42 [PATCH v2 0/3] i2c: spacemit: add reset support Encrow Thorne
2025-12-19  7:42 ` [PATCH v2 1/3] dt-bindings: i2c: spacemit: add optional resets Encrow Thorne
2025-12-19  8:03   ` Krzysztof Kozlowski
2025-12-26  3:25     ` Troy Mitchell [this message]
2025-12-19  7:42 ` [PATCH v2 2/3] i2c: k1: add reset support Encrow Thorne
2025-12-25 21:01   ` Andi Shyti
2025-12-25 23:38     ` Guodong Xu
2025-12-27 19:26       ` Andi Shyti
2025-12-28  0:42         ` Guodong Xu
2025-12-30 14:11           ` Troy Mitchell
2025-12-30 14:14             ` Troy Mitchell
2025-12-26  3:24   ` Troy Mitchell
2025-12-19  7:42 ` [PATCH v2 3/3] riscv: dts: spacemit: add reset property Encrow Thorne
2025-12-19  8:03 ` [PATCH v2 0/3] i2c: spacemit: add reset support Krzysztof Kozlowski
2025-12-27 23:53   ` Guodong Xu
2025-12-30 13:56     ` Encrow Thorne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=65A454B4ACFB1A38+aU4APFpyblOCKqJ4@kernel.org \
    --to=troy.mitchell@linux.spacemit.com \
    --cc=alex@ghiti.fr \
    --cc=andi.shyti@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlan@gentoo.org \
    --cc=guodong@riscstar.com \
    --cc=jyc0019@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=palmer@dabbelt.com \
    --cc=pjw@kernel.org \
    --cc=robh@kernel.org \
    --cc=spacemit@lists.linux.dev \
    --cc=troymitchell988@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox