From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-i2c@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Cc: Waiman Long <longman@redhat.com>,
linux-rt-devel@lists.linux.dev,
Andi Shyti <andi.shyti@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Subject: [BUG] exynos5_i2c_xfer_atomic() can sleep.
Date: Wed, 6 May 2026 08:51:10 +0200 [thread overview]
Message-ID: <20260506065110.sY3jKS7G@linutronix.de> (raw)
Hi,
While looking into the xfer_atomic i2c thingy, I've been looking at the
exynos5_i2c_xfer_atomic() function and noticed that it has a
disable_irq() invocation. Given that i2c_algorithm::xfer_atomic is
called from atomic context (with either preemption or interrupts
disabled) the might_sleep() in disable_irq() must lead to splat here.
This looks very light tested because exynos5_i2c_poll_irqs_timeout()
which should be invoked from atomic context has usleep_range(). This
will schedule from atomic context is not good. I *think* this gets back
with enabled interrupts.
Sebastian
reply other threads:[~2026-05-06 6:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506065110.sY3jKS7G@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=longman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox