* [BUG] exynos5_i2c_xfer_atomic() can sleep.
@ 2026-05-06 6:51 Sebastian Andrzej Siewior
0 siblings, 0 replies; only message in thread
From: Sebastian Andrzej Siewior @ 2026-05-06 6:51 UTC (permalink / raw)
To: linux-i2c, linux-samsung-soc
Cc: Waiman Long, linux-rt-devel, Andi Shyti, Krzysztof Kozlowski,
Alim Akhtar
Hi,
While looking into the xfer_atomic i2c thingy, I've been looking at the
exynos5_i2c_xfer_atomic() function and noticed that it has a
disable_irq() invocation. Given that i2c_algorithm::xfer_atomic is
called from atomic context (with either preemption or interrupts
disabled) the might_sleep() in disable_irq() must lead to splat here.
This looks very light tested because exynos5_i2c_poll_irqs_timeout()
which should be invoked from atomic context has usleep_range(). This
will schedule from atomic context is not good. I *think* this gets back
with enabled interrupts.
Sebastian
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-05-06 6:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-06 6:51 [BUG] exynos5_i2c_xfer_atomic() can sleep Sebastian Andrzej Siewior
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox