* [PATCH] i2c: I2C_DESIGNWARE_AMDISP should depend on DRM_AMD_ISP
@ 2025-05-06 13:02 Geert Uytterhoeven
2025-05-07 20:37 ` Nirujogi, Pratap
2025-05-08 10:06 ` Andi Shyti
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2025-05-06 13:02 UTC (permalink / raw)
To: Andi Shyti, Pratap Nirujogi, Bin Du, Mario Limonciello,
Venkata Narendra Kumar Gutta
Cc: linux-i2c, linux-kernel, Geert Uytterhoeven
The AMD Image Signal Processor I2C functionality is only present on AMD
platforms with ISP support, and its platform device is instantiated by
the AMD ISP driver. Hence add a dependency on DRM_AMD_ISP, to prevent
asking the user about this driver when configuring a kernel that does
not support the AMD ISP.
Fixes: 63f0545cb1bf0840 ("i2c: amd-isp: Add ISP i2c-designware driver")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/i2c/busses/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 865b760866ef42ba..7c348491e1bbac7c 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -594,6 +594,7 @@ config I2C_DESIGNWARE_PLATFORM
config I2C_DESIGNWARE_AMDISP
tristate "Synopsys DesignWare Platform for AMDISP"
+ depends on DRM_AMD_ISP || COMPILE_TEST
depends on I2C_DESIGNWARE_CORE
help
If you say yes to this option, support will be included for the
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: I2C_DESIGNWARE_AMDISP should depend on DRM_AMD_ISP
2025-05-06 13:02 [PATCH] i2c: I2C_DESIGNWARE_AMDISP should depend on DRM_AMD_ISP Geert Uytterhoeven
@ 2025-05-07 20:37 ` Nirujogi, Pratap
2025-05-08 10:06 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Nirujogi, Pratap @ 2025-05-07 20:37 UTC (permalink / raw)
To: Geert Uytterhoeven, Andi Shyti, Pratap Nirujogi, Bin Du,
Mario Limonciello, Venkata Narendra Kumar Gutta
Cc: linux-i2c, linux-kernel
Hi Geert,
Thanks for your patch.
On 5/6/2025 9:02 AM, Geert Uytterhoeven wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> The AMD Image Signal Processor I2C functionality is only present on AMD
> platforms with ISP support, and its platform device is instantiated by
> the AMD ISP driver. Hence add a dependency on DRM_AMD_ISP, to prevent
> asking the user about this driver when configuring a kernel that does
> not support the AMD ISP.
>
> Fixes: 63f0545cb1bf0840 ("i2c: amd-isp: Add ISP i2c-designware driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/i2c/busses/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 865b760866ef42ba..7c348491e1bbac7c 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -594,6 +594,7 @@ config I2C_DESIGNWARE_PLATFORM
>
> config I2C_DESIGNWARE_AMDISP
> tristate "Synopsys DesignWare Platform for AMDISP"
> + depends on DRM_AMD_ISP || COMPILE_TEST
> depends on I2C_DESIGNWARE_CORE
> help
> If you say yes to this option, support will be included for the
> --
> 2.43.0
>
LGTM.
Reviewed-by: Pratap Nirujogi <pratap.nirujogi@amd.com>
Thanks,
Pratap
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: I2C_DESIGNWARE_AMDISP should depend on DRM_AMD_ISP
2025-05-06 13:02 [PATCH] i2c: I2C_DESIGNWARE_AMDISP should depend on DRM_AMD_ISP Geert Uytterhoeven
2025-05-07 20:37 ` Nirujogi, Pratap
@ 2025-05-08 10:06 ` Andi Shyti
1 sibling, 0 replies; 3+ messages in thread
From: Andi Shyti @ 2025-05-08 10:06 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Pratap Nirujogi, Bin Du, Mario Limonciello,
Venkata Narendra Kumar Gutta, linux-i2c, linux-kernel
Hi Geert,
On Tue, May 06, 2025 at 03:02:06PM +0200, Geert Uytterhoeven wrote:
> The AMD Image Signal Processor I2C functionality is only present on AMD
> platforms with ISP support, and its platform device is instantiated by
> the AMD ISP driver. Hence add a dependency on DRM_AMD_ISP, to prevent
> asking the user about this driver when configuring a kernel that does
> not support the AMD ISP.
>
> Fixes: 63f0545cb1bf0840 ("i2c: amd-isp: Add ISP i2c-designware driver")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
merged to i2c/i2c-host.
Thanks,
Andi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-08 10:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-06 13:02 [PATCH] i2c: I2C_DESIGNWARE_AMDISP should depend on DRM_AMD_ISP Geert Uytterhoeven
2025-05-07 20:37 ` Nirujogi, Pratap
2025-05-08 10:06 ` Andi Shyti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox