From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/6] soc: qcom: geni-se: add support for I2C Master Hub wrapper variant
Date: Wed, 16 Nov 2022 11:32:39 +0100 [thread overview]
Message-ID: <3c2b2155-c4a5-306e-87a2-396eecdc239b@linaro.org> (raw)
In-Reply-To: <20221114-narmstrong-sm8550-upstream-i2c-master-hub-v1-4-64449106a148@linaro.org>
On 16/11/2022 11:21, Neil Armstrong wrote:
> The I2C Master Hub is a stripped down version of the GENI Serial Engine
> QUP Wrapper Controller but only supporting I2C serial engines without
> DMA support.
>
> This adds the clock list for the I2C Master Hub variant to a new desc
> struct then passes it through the I2C Master Hub compatible match data.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> drivers/soc/qcom/qcom-geni-se.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
> index f4f54d92a01a..8430a0192bb9 100644
> --- a/drivers/soc/qcom/qcom-geni-se.c
> +++ b/drivers/soc/qcom/qcom-geni-se.c
> @@ -930,8 +930,18 @@ static const struct geni_se_desc qup_desc = {
> .num_clks = ARRAY_SIZE(qup_clks),
> };
>
> +static const char * const i2c_master_hub_clks[] = {
> + "s-ahb",
> +};
> +
> +static const struct geni_se_desc i2c_master_hub_desc = {
> + .clks = i2c_master_hub_clks,
> + .num_clks = ARRAY_SIZE(i2c_master_hub_clks),
> +};
> +
> static const struct of_device_id geni_se_dt_match[] = {
> { .compatible = "qcom,geni-se-qup", .data = &qup_desc },
> + { .compatible = "qcom,geni-se-i2c-master-hub", .data = &i2c_master_hub_desc },
> {}
> };
> MODULE_DEVICE_TABLE(of, geni_se_dt_match);
>
next prev parent reply other threads:[~2022-11-16 10:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 10:21 [PATCH 0/6] soc: qcom: add support for the I2C Master Hub Neil Armstrong
2022-11-16 10:21 ` [PATCH 1/6] dt-bindings: qcom: geni-se: document I2C Master Hub wrapper variant Neil Armstrong
2022-11-17 14:43 ` Krzysztof Kozlowski
2022-11-16 10:21 ` [PATCH 2/6] dt-bindings: i2c: qcom-geni: document I2C Master Hub serial I2C engine Neil Armstrong
2022-11-17 14:44 ` Krzysztof Kozlowski
2022-11-16 10:21 ` [PATCH 3/6] soc: qcom: geni-se: add desc struct to specify clocks from device match data Neil Armstrong
2022-11-16 10:32 ` Konrad Dybcio
2022-11-17 7:58 ` Neil Armstrong
2022-11-16 10:21 ` [PATCH 4/6] soc: qcom: geni-se: add support for I2C Master Hub wrapper variant Neil Armstrong
2022-11-16 10:32 ` Konrad Dybcio [this message]
2022-11-16 10:21 ` [PATCH 5/6] i2c: qcom-geni: add desc struct to prepare support for I2C Master Hub variant Neil Armstrong
2022-11-16 10:38 ` Konrad Dybcio
2022-11-16 10:21 ` [PATCH 6/6] i2c: qcom-geni: add " Neil Armstrong
2022-11-16 10:38 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c2b2155-c4a5-306e-87a2-396eecdc239b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox