From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Pali Rohár" <pali@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Paul Menzel" <pmenzel@molgen.mpg.de>,
"Wolfram Sang" <wsa@kernel.org>,
eric.piel@tremplin-utc.net, "Marius Hoch" <mail@mariushoch.de>,
Dell.Client.Kernel@dell.com,
"Kai Heng Feng" <kai.heng.feng@canonical.com>,
platform-driver-x86@vger.kernel.org,
"Jean Delvare" <jdelvare@suse.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v7 3/6] platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to dell-smo8800-ids.h
Date: Mon, 12 Aug 2024 17:55:08 +0200 [thread overview]
Message-ID: <3e483c97-a92a-4229-ae38-2e599b0f474d@redhat.com> (raw)
In-Reply-To: <CAHp75VckqF6==cJ7xoXXn3hr9kzYn7+oHqYZq01S5HEe9eK_-Q@mail.gmail.com>
Hi,
On 8/5/24 10:27 PM, Andy Shevchenko wrote:
> On Mon, Aug 5, 2024 at 3:38 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> Move the SMO88xx acpi_device_ids to a new dell-smo8800-ids.h header,
>> so that these can be shared with the new dell-lis3lv02d code.
>
> ...
>
>> +#ifndef _DELL_SMO8800_IDS_H_
>> +#define _DELL_SMO8800_IDS_H_
>> +
>> +#include <linux/mod_devicetable.h>
>> +
>> +static const struct acpi_device_id smo8800_ids[] = {
>> + { "SMO8800" },
>> + { "SMO8801" },
>> + { "SMO8810" },
>> + { "SMO8811" },
>> + { "SMO8820" },
>> + { "SMO8821" },
>> + { "SMO8830" },
>> + { "SMO8831" },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(acpi, smo8800_ids);
>
> The macro definition is in module.h.
Ok, I've added a #include for that for v8.
Regards,
Hans
next prev parent reply other threads:[~2024-08-12 15:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 13:37 [PATCH v7 0/6] i2c-i801 / dell-lis3lv02d: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d Hans de Goede
2024-08-05 13:37 ` [PATCH v7 1/6] i2c: core: Setup i2c_adapter runtime-pm before calling device_add() Hans de Goede
2024-08-05 13:37 ` [PATCH v7 2/6] i2c: i801: Use a different adapter-name for IDF adapters Hans de Goede
2024-08-05 13:37 ` [PATCH v7 3/6] platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to dell-smo8800-ids.h Hans de Goede
2024-08-05 20:27 ` Andy Shevchenko
2024-08-12 15:55 ` Hans de Goede [this message]
2024-08-05 13:37 ` [PATCH v7 4/6] platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d Hans de Goede
2024-08-05 20:48 ` Andy Shevchenko
2024-08-12 16:00 ` Hans de Goede
2024-08-12 17:03 ` Andy Shevchenko
2024-08-12 20:29 ` Hans de Goede
2024-08-05 13:37 ` [PATCH v7 5/6] platform/x86: dell-smo8800: Add a couple more models to lis3lv02d_devices[] Hans de Goede
2024-08-05 13:37 ` [PATCH v7 6/6] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address Hans de Goede
2024-08-05 20:51 ` Andy Shevchenko
2024-08-12 20:30 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e483c97-a92a-4229-ae38-2e599b0f474d@redhat.com \
--to=hdegoede@redhat.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=andi.shyti@kernel.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=eric.piel@tremplin-utc.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mail@mariushoch.de \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox