From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Pali Rohár" <pali@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Paul Menzel" <pmenzel@molgen.mpg.de>,
"Wolfram Sang" <wsa@kernel.org>,
eric.piel@tremplin-utc.net, "Marius Hoch" <mail@mariushoch.de>,
Dell.Client.Kernel@dell.com,
"Kai Heng Feng" <kai.heng.feng@canonical.com>,
platform-driver-x86@vger.kernel.org,
"Jean Delvare" <jdelvare@suse.com>,
"Andi Shyti" <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v7 4/6] platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d
Date: Mon, 12 Aug 2024 20:03:09 +0300 [thread overview]
Message-ID: <ZrpATebaOpSJyBca@smile.fi.intel.com> (raw)
In-Reply-To: <3a4f4c6c-3069-412e-9c71-b4e0308fccd4@redhat.com>
On Mon, Aug 12, 2024 at 06:00:20PM +0200, Hans de Goede wrote:
> On 8/5/24 10:48 PM, Andy Shevchenko wrote:
> > On Mon, Aug 5, 2024 at 3:38 PM Hans de Goede <hdegoede@redhat.com> wrote:
...
> >> + bus_for_each_dev(&i2c_bus_type, NULL, &adap, find_i801);
> >> + if (!adap)
> >> + return;
> >
> > May i2c_for_each_dev() be used here?
>
> The main difference between i2c_for_each_dev() and
> bus_for_each_dev() is that i2c_for_each_dev() holds
> the i2c core mutex while it is calling the passed
> in callback.
>
> And find_i801() calls i2c_get_adapter() which also
> takes the i2c core mutex, so i2c_for_each_dev()
> cannot be used here since then things deadlock.
+ A comment to prevent "clever" cleanupers from breaking the things?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-12 17:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 13:37 [PATCH v7 0/6] i2c-i801 / dell-lis3lv02d: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d Hans de Goede
2024-08-05 13:37 ` [PATCH v7 1/6] i2c: core: Setup i2c_adapter runtime-pm before calling device_add() Hans de Goede
2024-08-05 13:37 ` [PATCH v7 2/6] i2c: i801: Use a different adapter-name for IDF adapters Hans de Goede
2024-08-05 13:37 ` [PATCH v7 3/6] platform/x86: dell-smo8800: Move SMO88xx acpi_device_ids to dell-smo8800-ids.h Hans de Goede
2024-08-05 20:27 ` Andy Shevchenko
2024-08-12 15:55 ` Hans de Goede
2024-08-05 13:37 ` [PATCH v7 4/6] platform/x86: dell-smo8800: Move instantiation of lis3lv02d i2c_client from i2c-i801 to dell-lis3lv02d Hans de Goede
2024-08-05 20:48 ` Andy Shevchenko
2024-08-12 16:00 ` Hans de Goede
2024-08-12 17:03 ` Andy Shevchenko [this message]
2024-08-12 20:29 ` Hans de Goede
2024-08-05 13:37 ` [PATCH v7 5/6] platform/x86: dell-smo8800: Add a couple more models to lis3lv02d_devices[] Hans de Goede
2024-08-05 13:37 ` [PATCH v7 6/6] platform/x86: dell-smo8800: Add support for probing for the accelerometer i2c address Hans de Goede
2024-08-05 20:51 ` Andy Shevchenko
2024-08-12 20:30 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrpATebaOpSJyBca@smile.fi.intel.com \
--to=andy.shevchenko@gmail.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=andi.shyti@kernel.org \
--cc=eric.piel@tremplin-utc.net \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-i2c@vger.kernel.org \
--cc=mail@mariushoch.de \
--cc=pali@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=pmenzel@molgen.mpg.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox