Re: [PATCH v16 1/3] dt-bindings: i2c: aspeed: support for AST2600-i2cv2

[Jeremy Kerr <jk@ozlabs.org>]

Hi Ryan,

> Sorry, for ambiguous.
> The global register like a mux selection for new/old register layout.
> Like following example.

That wasn't the ambiguous part - I think we are clear that there is a
multiplexer that controls what registers appear at the node's bus
address.

The question was more: it sounds like you're switching between
*fundamentally different* hardware units with the mux switch - not just
a different register interface for the same peripheral hardware. Is that
the case?

This is an important distinction in that some SoCs have the old
peripheral, some have the new, and some have the mux-switching between
both.

Behaviour of those two peripheral options differs beyond just a
"register interface", and calling it just a change in register layout is
misguiding the conversation somewhat.

If that's the case, then the separate compatible values may make more
sense.

Cheers,


Jeremy